Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Correcting discrepancies between current_transform() and matches #39

Open
Yey007 opened this issue Dec 11, 2024 · 1 comment
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@Yey007
Copy link
Member

Yey007 commented Dec 11, 2024

Jess has been working on a new match display. Thanks to her work, we've discovered a number of bugs in how matches work right now. Due to the way iterate works, matches is usually one iteration behind current_transform() (except right after begin()) and thus functions like calculate_cost() are technically wrong. I don't know the best way to correct this right now, but it needs to happen.

@Yey007 Yey007 added bug Something isn't working enhancement New feature or request labels Dec 11, 2024
@Yey007
Copy link
Member Author

Yey007 commented Dec 11, 2024

One option: force implementing classes to have a method that updates matches. Call it when necessary. Leads to unnecessary calls when using calculate_cost in a tight loop, though. Can potentially be rectified by keeping track of when things are stale? This seems annoying. Will get back to it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant