-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nifti): NIFTI data type enhancement #1219
Conversation
…32 (cornerstonejs#964) * feat(Nifti): support uint8 nifti files (cornerstonejs#791) * fix(Nifti): scale negetive and float result is not considered. Skip scale if scale_slope is 1 and scale_inter is 0
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This PR is very important to my project. |
packages/core/src/RenderingEngine/helpers/setDefaultVolumeVOI.ts
Outdated
Show resolved
Hide resolved
packages/core/src/RenderingEngine/helpers/setDefaultVolumeVOI.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @sedghi
I found more int8_t images for testing, CT_Abdo, CT_Electrodes, etc. from niivue-images. For other images, most of them are OK except visiblehuman.nii.gz which is a RGB image and chris_MRA.nii.gz which need update nifti-reader-js to 0.6.8. Also I found a bug of _getImageScalarDataFromImageVolume() in setDefaultVolumeVOI.ts Other codes are adjusted to make the code structure clearer Please review it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome now, thanks
Context
Changes & Results
Testing
The test data is provided by #791(pull request #1033) and #964
https://raw.githubusercontent.com/alfnie/conn/master/utils/surf/referenceT1.nii
https://drive.google.com/file/d/1sLOBm3PGT2XOAWdPRdcyMLZ7tOB9fCcT/view?usp=drive_link
Following is the compare results with NiiVue(RAS) and ITK-SNAP(LPS)
INT16
UINT8
UINT8 with float scaler
Checklist
PR
semantic-release format and guidelines.
Code
My code has been well-documented (function documentation, inline comments,
etc.)
I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment