-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rendering): Allow memory sizes between 2gb and 4gb by using wasm allocation #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vitalii-komenda
approved these changes
May 21, 2024
works great on orthanc but seems there's some issues when using P10 dicom from local |
sedghi
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked great, see my FYIs that i fixed
sedghi
approved these changes
May 21, 2024
sedghi
changed the title
fix: Allow memory sizes between 2gb and 4gb by using wasm allocation
fix(rendering): Allow memory sizes between 2gb and 4gb by using wasm allocation
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Browsers don't allow allocation of more than 2gb memory using the standard buffer allocators. This PR adds the ability to allocate using the WebAssembly.Memory allocator, which seems to work fine up to 4 gb, although the GPU does complain about memory texture size limits.
Changes & Results
Added a test example, using local data for now (and so not in the shared examples), plus changed the createFloat32SharedArray to use WebAssembly.Memory
Testing
Deploy the test data to localhost:5000/dicomweb
Run
yarn example volumeLarge
View the page, should display (may still be browser dependent).
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment