examples: Add image (ijk) coordinates to stackCanvasToWorld example #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kom482
reviewed
Jun 2, 2024
Comment on lines
115
to
117
| imagePosElement.innerText = `image (ijk): (${imagePos[0].toFixed( | ||
| 2 | ||
| )}, ${imagePos[1].toFixed(2)}, ${imagePos[2].toFixed(2)})`; |
There was a problem hiding this comment.
I have a small suggestion that might help improve the readability and maintainability of the code:
const [i, j, k] = imagePos.map(item => item.toFixed(2));
imagePosElement.innerText = `image (ijk): (${i}, ${j}, ${k})`;
There was a problem hiding this comment.
I was trying the github copilot workspace to see if it works haha, i guess your suggestion makes sense
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #391
Updates the
stackCanvasToWorldexample to includeimage (ijk)coordinates alongsidecanvasandworldcoordinates.worldToImageCoordsutility from@cornerstonejs/coreto facilitate the conversion of world coordinates to image (ijk) coordinates.image (ijk)coordinates, enhancing the example's output with additional information.image (ijk)coordinates using theworldToImageCoordsutility and displays these coordinates in the newly added UI element.For more details, open the Copilot Workspace session.