fix(ArrowAnnotate): use svg marker to draw the arrow #1732
+55
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
❌ Deploy Preview for cornerstone-3d-docs failed. Why did it fail? →
|
daker
force-pushed
the
fix-arrowannotate
branch
from
baa240c to
566ab17
Compare
sedghi
reviewed
Jan 6, 2025
| ); | ||
| const { | ||
| color = 'rgb(0, 255, 0)', | ||
| width = 10, |
There was a problem hiding this comment.
Why are we changing the width here? Could this break people's tools since we're changing it from 2 to 10?
sedghi
reviewed
Jan 6, 2025
|
|
||
| if (arrow) { | ||
| arrow.setAttribute('fill', color); | ||
| const newstrokeWidth = strokeWidth >= 4 ? 3 : 6; |
There was a problem hiding this comment.
Why is strokeWidth >= 4 ? 3 : 6; used here? It seems arbitrary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
fix #1671
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment