Fix undefined window error in logger #1897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Logger accesses
window
object which can beundefined
if used in wasm worker. For example, check the Volume Labelmap to Surface example - segment some part and try to convert the labelmap to surface segmentation, you'll get the error below:Uncaught (in promise) ReferenceError: window is not defined
Changes & Results
Added check for undefined window. If window is undefined, then skip setting the log level.
Testing
Tested by running the example mentioned above and making sure it runs correctly.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment