[Feature] Package the project as a ng library and more #1
+15,923
−400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cornflourblue ,
Thanks for this project! I was about to write something very similar, when i came accross your blog. The project has almost everything i needed and is very well written, Good job 👍
One little caveat though, the project is a bit cumbersome to integrate in a real-world ng project (need to copy/paste files around :(, ... )
So i'm submitting this PR, which basically makes a library out-of your code, for easy integration in ng projects, like any other angular libraries.
This was pretty straightforward, using a tool i created for that exact purpose.
So, what you'll get out of the box:
npm install <lib-name>
compodoc
Travis CI
gulp
Here is what the demo app looks like (notice the brand new logo :) ) :
A bit more info:
ngx-alert-notifications
, to make @IgorMinar happy! (#ItsJustAngular)Nga
and components bynga
to follow naming conventions and best practices (see ng-bootstrap project for example)To play around locally with the PR:
yarn
ornpm install
from root foldergulp build
to build the libraryyarn
ornpm install
fromdemo/
foldergulp serve:demo
(from root folder) to see the demo app (http:localhost:4200)If you merge the PR, here are a couple of things you must adjust:
ngx-alert-notifications
.git/config
file in the project folder, to point to the new URL :https://github.com/cornflourblue/ngx-alert-notifications.git
.yo-rc.json
,package.json
files (this is not mandatory)To publish:
gulp release version=major
That it!
I plan to submit more PRs to improve the library in the future.
If you have a question, drop me a line!
Cheers!