-
Notifications
You must be signed in to change notification settings - Fork 105
Registration token refactor #260
base: master
Are you sure you want to change the base?
Registration token refactor #260
Conversation
Hi @damirseit , your code needs some style refactoring - please have a look in the build output here and fix these issues :) You can also run |
Hi @f11h! Thank you! It feels like I have resolved all of the style warnings and pushed it to my branch. It is written here that I need a maintainer. How can I specify one, and can you be a maintainer for me? :) Thanks in advance. |
@f11h @ascheibal If you have some spare time, could you review my PR? Thanks in advance! |
Hi @damirseit, yes I will check your PR as soon as I have time for it :) |
Dear @f11h @ascheibal, I am sorry to bother you again. If I have to make any changes, could you please let me know? Thanks in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my hints at #264 regarding Dependency Injection
Addressing the issue described in the comments section of:
#61
@alstiefel @dfischer-tech @f11h @jhagestedt @mlaue-tech @mschulte-tsi @tence @kreincke @ascheibal @BugBuster1701