Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Registration token refactor #260

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

damirseit
Copy link

Addressing the issue described in the comments section of:

#61

@alstiefel @dfischer-tech @f11h @jhagestedt @mlaue-tech @mschulte-tsi @tence @kreincke @ascheibal @BugBuster1701

@f11h
Copy link
Member

f11h commented Feb 28, 2022

Hi @damirseit ,

your code needs some style refactoring - please have a look in the build output here and fix these issues :)
https://github.com/corona-warn-app/cwa-verification-server/runs/5356343880

You can also run mvn checkstyle:check to execute the style-checks locally.

@damirseit
Copy link
Author

Hi @f11h!

Thank you! It feels like I have resolved all of the style warnings and pushed it to my branch. It is written here that I need a maintainer. How can I specify one, and can you be a maintainer for me? :)

Thanks in advance.

@damirseit
Copy link
Author

@f11h @ascheibal
Dear reviewers,

If you have some spare time, could you review my PR?

Thanks in advance!

@f11h
Copy link
Member

f11h commented Mar 1, 2022

Hi @damirseit, yes I will check your PR as soon as I have time for it :)

@damirseit
Copy link
Author

Dear @f11h @ascheibal,

I am sorry to bother you again. If I have to make any changes, could you please let me know? Thanks in advance.

Copy link
Member

@f11h f11h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my hints at #264 regarding Dependency Injection

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants