Skip to content

Commit

Permalink
CI: Stop caching the msvc build dir
Browse files Browse the repository at this point in the history
This breaks when the msvc version in the runner image gets updated.
If we could figure out the location / version of the selected msvc
toolchain, we could add the toolchain to the cache key.
  • Loading branch information
jschwe committed Nov 23, 2024
1 parent a02953b commit b816285
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/visual_studio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ jobs:
# The initial configure for MSVC is quite slow, so we cache the build directory
# (including the build directories of the tests) since reconfiguring is
# significantly faster.
- name: Cache MSVC build directory
id: cache-msvc-builddir
uses: actions/cache@v4
with:
path: build
key: ${{ inputs.os }}-${{ inputs.target_arch }}-${{ inputs.rust }}-msvc-${{ inputs.vs_version}}-build
# - name: Cache MSVC build directory
# id: cache-msvc-builddir
# uses: actions/cache@v4
# with:
# path: build
# key: ${{ inputs.os }}-${{ inputs.target_arch }}-${{ inputs.rust }}-msvc-${{ inputs.vs_version}}-build
- name: Configure
run: cmake -S. -Bbuild -DCORROSION_TESTS_KEEP_BUILDDIRS=ON "-DRust_TOOLCHAIN=${{steps.install_rust.outputs.name}}" --preset "vs-${{ inputs.vs_version }}-${{ inputs.target_arch }}"
- name: Run Tests
Expand Down

0 comments on commit b816285

Please sign in to comment.