Don't treat -framework as a library to link to, treat it as a composite arg #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
reviewed
Nov 14, 2023
jschwe
force-pushed
the
fix_framework_linkage
branch
from
3851d39 to
21ad90a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because CMake de-duplicates libraries, we had a situation where cargo was reporting
-framework A -framework Bas its native static libs, this ended up on the link commandline as-framework A B, which is is not correct (the -framework flag is required).CMake deals with this by combining them, and they will be properly passes as separate flags on the final link commandline.
This fixes our internal app which uses corrosion, so is at least moderately tested
Questions