-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change alertmanager-svc-headless from http to grpc port + expose 9094 TCP and UDP #435
Open
humblebundledore
wants to merge
14
commits into
cortexproject:master
Choose a base branch
from
humblebundledore:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dcc7660
change alertmanager-svc-headless from http to grpc port
humblebundledore d8bdc70
edit CHANGELOG.md
humblebundledore a001e49
expose 9094 TCP UDP for gossip cluster
humblebundledore b0df50e
Merge branch 'master' into master
humblebundledore e483cd5
support configuration of gossip cluster port
humblebundledore 84c1331
Merge branch 'master' into master
humblebundledore 05b3403
WIP: configure alertmanager HA cluster mode for sts
nschad d29022e
Merge branch 'cortexproject:master' into master
humblebundledore 8d22e3a
Merge remote-tracking branch 'upstream/feature/alertmanager-cluster'
humblebundledore 1d830da
configure alertmanager cluster peers as comma seperated list
humblebundledore e909803
clarify values.yaml about cluster enable by default
humblebundledore b9efaee
replicaset should not set -alertmanager-cluster-peers when cluster is…
humblebundledore 87e6eb4
fix wrong name for grpc targetPort
humblebundledore 62c1222
re-introduce alertmanager-dep.yaml
humblebundledore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm conflicted on this. The magic number
9094
bothers me. It would be nice to be able to support the configuration and only default to9094
, but that's awkward because the port number is embedded at the end of the listen string. Something like this (but this is kind of ugly):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about introducing an extra variable with a docstring in
values.yaml
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't manage to figure out a way rather than the above suggestion of @kd7lxl to make 9094 configurable since it will always come from
config.alertmanager.cluster.listen_address
and the need to split the port at the end.I will push that for now (to progress on the PL) but suggestion are welcome.