-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change headless service to gRPC and expose 9094 TCP #494
Conversation
Signed-off-by: AlexandreRoux <[email protected]>
Signed-off-by: AlexandreRoux <[email protected]>
Signed-off-by: AlexandreRoux <[email protected]>
Signed-off-by: AlexandreRoux <[email protected]>
Signed-off-by: Niclas Schad <[email protected]>
Signed-off-by: AlexandreRoux <[email protected]>
Signed-off-by: AlexandreRoux <[email protected]>
… disable Signed-off-by: AlexandreRoux <[email protected]>
Signed-off-by: AlexandreRoux <[email protected]>
Signed-off-by: AlexandreRoux <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
af2d7b5
to
bd4b07f
Compare
name: http-metrics | ||
targetPort: http-metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should inform the user about this breaking chance in CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the CHANGELOG.md to make this clearer. Or do you think we should add a better indication that this may break if users were using the http-metrics
port for their own usage? Similar to the old PR we have here #169
And by breaking - do you mean we should make it to v3 (too much I think?) or a line in the CHANGELOG should be good enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just not touch the http-metrics
port, so that there is no breaking change. Adding gRPC has nothing to do with the http-metrics
port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good. Let me update that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
CHANGELOG.md
Outdated
* [CHANGE] Alertmanager: Add `grpc` port #494 | ||
* [CHANGE] Alertmanager: Expose 9094 TCP and UDP for gossip cluster #494 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be ENHANCEMENT
.
Signed-off-by: Loc Mai <[email protected]>
What this PR does
Follow-up the work of @AlexandreRoux from #435 and related to #420 to run the helm-docs for the README.md
I tested the Helm chart and I can't reproduce the EOF issue.