-
Notifications
You must be signed in to change notification settings - Fork 826
Remove references to max_series_per_query
from docs
#6889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove references to max_series_per_query
from docs
#6889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. Just some small comments. Maybe we can replace max_series_per_query
to the new limit name and also remove max_samples_per_query
@@ -316,11 +316,9 @@ overrides: | |||
tenant1: | |||
ingestion_rate: 10000 | |||
max_series_per_metric: 100000 | |||
max_series_per_query: 100000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably change max_series_per_query
to max_fetched_series_per_query
as it is the new limit.
docs/configuration/arguments.md
Outdated
@@ -316,11 +316,9 @@ overrides: | |||
tenant1: | |||
ingestion_rate: 10000 | |||
max_series_per_metric: 100000 | |||
max_series_per_query: 100000 | |||
tenant2: | |||
max_samples_per_query: 1000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also remove max_samples_per_query? It is removed as well
@aclaygray thank you!. Do you mind also signing the DCO? |
7655266
to
aa7c67c
Compare
Remove references to max_samples_per_query from docs Signed-off-by: Andrew Gray <[email protected]>
aa7c67c
to
ee93cff
Compare
What this PR does:
Updates documentation to remove reference to deprecated
max-series-per-query
that was removed here, but some of its documentation remained.I found these during an investigation to why I received the following error when upgrading from
1.17.1
to1.19.0
:Figured it would save someone else some time if it were to pop up after copying over some existing examples from the docs.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]