Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in settings key accesses #277

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix typos in settings key accesses #277

wants to merge 1 commit into from

Conversation

cameronblandford
Copy link
Contributor

While the rest of collections has migrated to kebab case, for some reason these poor keys have been forgotten in the dust. This commit rescues them, giving them something warm to eat and apologizing for being so neglectful.

While the rest of collections has migrated to kebab case, for some reason these poor keys have been forgotten in the dust. This commit rescues them, giving them something warm to eat and apologizing for being so neglectful.
@NyanHelsing
Copy link
Contributor

does this still work? technically these are POJOs, and should have camelCase the reason they are now kebab I think is because we're preferring kebab in JSON. the fix here ought to be in the serializer to change all the kebab to camel and use camel in the spots changed above^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants