Rescale Initial Node Positions #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stukova
force-pushed
the
fix/scaling-node-positions
branch
from
7d44ee3 to
2029c58
Compare
rokotyan
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when nodes had initial positions with negative X or Y values, the Many Body force pushed these nodes towards the left or right boundaries. This issue occurred because the boundaries were simulated in a space from 0 to
spaceSizevalue.We decided to rescale the initial coordinates of the nodes to fit the simulation space while preserving the proportion. This ensures that nodes with negative initial positions are correctly handled and prevents them from being pushed to the boundaries.