Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in keplr and utils using fixture files instead of exported assets and ibcs #66

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

Zetazzz
Copy link
Contributor

@Zetazzz Zetazzz commented Feb 19, 2024

"coingecko_id": "pstake-finance",
"denom_units": [
{
"aliases": [
"ibc/A6E3AF63B3C906416A9AF7A556C59EA4BD50E617EFFE6299B99700CCB780E444",
],
"denom": "ibc/CF780ADED86E541AD7A8D5B7D33D2E3D9C61D8ECD228B8ED951986D782CB630A",
"denom": "ibc/8061A06D3BD4D52C4A28FFECF7150D370393AF0BA661C3776C54FF32836C3961",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changed? that's likely not something we want, let's double check this one — this is actually the original reason for the special assets test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps because the the addition of new traces — let's see what the. previous values for traces were, and see if that fixes the value, so we can ensure the calculations are done right

        "traces": [
          {
            "type": "liquid-stake",
            "counterparty": {
              "chain_name": "persistence",
              "base_denom": "uxprt"
            },
            "provider": "Persistence"
          },
          {
            "type": "bridge",
            "counterparty": {
              "chain_name": "ethereum",
              "base_denom": "0xfB5c6815cA3AC72Ce9F5006869AE67f18bF77006"
            },
            "provider": "Gravity Bridge"
          },
          {
            "type": "ibc",
            "counterparty": {
              "chain_name": "gravitybridge",
              "base_denom": "gravity0xfB5c6815cA3AC72Ce9F5006869AE67f18bF77006",
              "channel_id": "channel-24"
            },
            "chain": {
              "channel_id": "channel-38",
              "path": "transfer/channel-38/gravity0xfB5c6815cA3AC72Ce9F5006869AE67f18bF77006"
            }
          }
        ],

@Zetazzz Zetazzz merged commit 67a7ae0 into main Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants