don't call experimentalSuggestChain() if it's natively supported #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eady. No need to register.
pyramation
commented
Jun 18, 2024
| keplrExtensionInfo.supportedChains && | ||
| keplrExtensionInfo.supportedChains.length | ||
| ) { | ||
| if (keplrExtensionInfo.supportedChains.includes(chainInfo.name)) { |
There was a problem hiding this comment.
@theothersideofgod make sure chainInfo.name is chain_name
pyramation
commented
Jun 18, 2024
| ) { | ||
| if (keplrExtensionInfo.supportedChains.includes(chainInfo.name)) { | ||
| console.warn( | ||
| `${chainInfo.name} is already added. No need to call experimentalSuggestChain()` |
There was a problem hiding this comment.
remove this after verifying that it works correctly @theothersideofgod
pyramation
commented
Jun 18, 2024
| 'osmosis', | ||
| 'persistence', | ||
| 'regen', | ||
| 'secretnetwork', |
There was a problem hiding this comment.
add any one of these chains to test if it still works, then we've succeeded — using the useChains hook @theothersideofgod
There was a problem hiding this comment.
test
- checkout the branch of this PR, in the
useChainsexample in the package - a) add a chain like osmosis that is "supported"
- b) add a chain like noise that is not supported
both should work, and provide an address at least, with no errors from cosmos-kit
pyramation
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eady. No need to register.