Support private docker images

[Inkvi]

No description provided.

[Anmol1696]

This is something we would have to make for all the images then, and not just the chain images. I wonder if there is a way to have docker image secrets so that it can pull from public and private registries.

We would also need to expose this in the values.yaml file for the helm chart. There should be information around how helm handles image pull secrets.

[Inkvi]

This is something we would have to make for all the images then, and not just the chain images.

I added the private image support for the go-relayer in #147. I can extend it to other relayers. For other types of services I don't see a necessity for private images.

I wonder if there is a way to have docker image secrets so that it can pull from public and private registries.
Not sure what you mean by that. Any docker image secret should be able to pull from a public registry. For private docker images, you have to be explicit with k8s. I didn't find a way for k8s just to pick up the authorizations docker already has.

We would also need to expose this in the values.yaml file for the helm chart. There should be information around how helm handles image pull secrets.

imagePullSecrets is not a required parameter so I don't think you have to modify values.yaml. For example, I was able to test polymer chain with the current values.yaml and this config:

  - name: polymer
    type: custom
    numValidators: 1
    image: ghcr.io/polymerdao/polymer:v0.0.1-rc4
    home: /home/heighliner/.polymer
    binary: polymerd
    prefix: polymer
    denom: token
    coins: 100000000000000token
    hdPath: m/44'/118'/0'/0/0
    coinType: 118
    repo: https://github.com/polymerdao/polymerase/
    imagePullSecrets:
      - name: ghcr

[Inkvi]

@Anmol1696 I did a little bit of refactoring and put the logic into a helper

[Anmol1696]

Since this is added to go-relayer, it might just make sense to add it to other relayers, explorers and others too.
What do you think?

[Anmol1696]

LGTM