Add CDT & MBRN ics20s to Stargaze #4718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stargaze/assetlist.json
Outdated
| "name": "CDT", | ||
| "display": "CDT", | ||
| "symbol": "CDT", | ||
| "logo_URIs": { |
There was a problem hiding this comment.
Please do not add logo_URIs--this is a legacy property.
stargaze/assetlist.json
Outdated
| ], | ||
| "images": [ | ||
| { | ||
| "png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/osmosis/images/CDT.svg", |
There was a problem hiding this comment.
you have the property png but the extension svg, which doesn't match and causing validation failure
osmosis/assetlist.json
Outdated
| @@ -17974,6 +17974,25 @@ | |||
| "png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/osmosis/images/COCA.png" | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "description": "Memecoin for The International Brane Wave", | |||
There was a problem hiding this comment.
Why re-registering BRNZ?
There was a problem hiding this comment.
wasn't trying to, must've been an old commit
|
moved to #4719 after deleting old commits and making the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the denom_traces for confirmation
CDT: https://rest.cosmos.directory/stargaze/ibc/apps/transfer/v1/denom_traces/B0263C28B6F44651F4596413B41FDB749EA010BD1220816DAC0ABF9947C1E806
MBRN: https://rest.cosmos.directory/stargaze/ibc/apps/transfer/v1/denom_traces/E94BB144B818CB8061F43E202BEA1E9273B87D6326C8C6F4E6AE71C62FD37854