Add Hippo Protocol #6253
Merged
Add Hippo Protocol #6253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisCho-H
force-pushed
the
master
branch
2 times, most recently
from
95986cc to
d9db70b
Compare
| "chain_type": "cosmos", | ||
| "chain_id": "hippo-protocol-1", | ||
| "bech32_prefix": "hippo", | ||
| "slip44": 0, |
There was a problem hiding this comment.
Please enter the appropriate slip44
There was a problem hiding this comment.
We are deliberately using cointype of 0.
https://github.com/hippo-protocol/hippo-protocol/blob/main/types/consensus/wallet.go#L18
There was a problem hiding this comment.
Thanks for explaining. I've updated that verification check, could you please merge master into this branch so the check is updated?
hippoprotocol/versions.json
Outdated
| "consensus": { | ||
| "type": "cometbft", | ||
| "repo": "https://github.com/cometbft/cometbft", | ||
| "version": "v0.38.7", |
There was a problem hiding this comment.
Looks like there are still some version value mismatches. If data is repeated in the chain.json file, then it must match the version as specified in this file.
Path: consensus.version, Reason: Value mismatch, In "codebase": v0.38.17, In currentVersion: v0.38.7
Path: consensus.tag, Reason: Value mismatch, In "codebase": v0.38.17, In currentVersion: v0.38.7
Path: language.version, Reason: Value mismatch, In "codebase": 1.23.0, In currentVersion: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Hippo Protocol mainnet.
https://github.com/hippo-protocol/hippo-protocol