Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove collections.ErrInvalidIterator when unecessary #17364

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

julienrbrt
Copy link
Member

Description

Follow-up of #17289
Closes: #17310

We should backport this in v0.50, however I'll submit a PR to v0.50 branch directly as v0.50 has a partial migration to collections, so backporting this will give a conflict hell.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:x/distribution distribution module related C:x/bank labels Aug 11, 2023
@julienrbrt julienrbrt marked this pull request as ready for review August 11, 2023 10:49
@julienrbrt julienrbrt requested a review from a team as a code owner August 11, 2023 10:49
@julienrbrt julienrbrt added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit 77be10b Aug 11, 2023
49 of 50 checks passed
@julienrbrt julienrbrt deleted the julien/errinvalidit branch August 11, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove instances of errors.Is(collections.ErrInvalidIterator...
2 participants