-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store/v2): build the migration manager in the root store factory #22336
Draft
cool-develope
wants to merge
13
commits into
main
Choose a base branch
from
store/factory_migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,012
−19
Draft
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6362846
confgi the migration manager in root factory
cool-develope e7bd885
minor fix
cool-develope 3bb541b
add simple test
cool-develope 1e6e4f1
small fix
cool-develope cb86a77
Merge branch 'main' into store/factory_migration
cool-develope 31eb8fd
fix migration
cool-develope 79d978b
Merge branch 'main' into store/factory_migration
cool-develope eb8029c
fix db close
cool-develope 01a470e
Merge branch 'main' into store/factory_migration
cool-develope f3091f5
Merge branch 'main' into store/factory_migration
tac0turtle 19c6da3
go mod change
tac0turtle f58431a
fix diff
tac0turtle 4ef10b7
fix factory
tac0turtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ import ( | |
|
||
errors "cosmossdk.io/errors/v2" | ||
storeerrors "cosmossdk.io/store/v2/errors" | ||
v1types "cosmossdk.io/store/v2/proof/v1/types" | ||
) | ||
|
||
// Proof operation types | ||
|
@@ -228,3 +229,30 @@ func InnerHash(left, right []byte) []byte { | |
h := sha256.Sum256(data) | ||
return h[:] | ||
} | ||
|
||
func ConvertV1CommitInfo(value []byte) (*CommitInfo, error) { | ||
v1CommitInfo := &v1types.CommitInfo{} | ||
if err := v1CommitInfo.Unmarshal(value); err != nil { | ||
return nil, err | ||
} | ||
cInfo := &CommitInfo{ | ||
Version: uint64(v1CommitInfo.Version), | ||
StoreInfos: make([]StoreInfo, len(v1CommitInfo.StoreInfos)), | ||
Timestamp: v1CommitInfo.Timestamp, | ||
} | ||
for i, v1StoreInfo := range v1CommitInfo.StoreInfos { | ||
cInfo.StoreInfos[i] = StoreInfo{ | ||
Name: []byte(v1StoreInfo.Name), | ||
CommitID: CommitID{ | ||
Version: uint64(v1StoreInfo.CommitId.Version), | ||
Hash: v1StoreInfo.CommitId.Hash, | ||
}, | ||
Structure: "iavl", | ||
} | ||
Comment on lines
+244
to
+251
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid hardcoding store structure type Hardcoding "iavl" as the Structure value is risky as not all stores might use IAVL. Consider:
- Structure: "iavl",
+ Structure: determineStoreStructure(v1StoreInfo),
|
||
} | ||
|
||
var err error | ||
cInfo.CommitHash, _, err = cInfo.GetStoreProof([]byte{}) | ||
|
||
return cInfo, err | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not return an error here? Is there ever a case where calling this with this invalid version is valid?