refactor(cosmovisor): get block height from db after node execution fails #23720
Conversation
📝 WalkthroughWalkthroughThis pull request updates the dependency management in the Changes
Sequence Diagram(s)sequenceDiagram
participant FW as fileWatcher
participant CH as checkHeight
participant DB as Database/BlockStore
FW->>CH: Trigger height check
CH->>FW: Call IsStop()
alt Watcher is stopped
CH->>DB: Execute command to get DB backend type
DB-->>CH: Return backend configuration
CH->>DB: Create new DB instance
DB-->>CH: Retrieve current block height
else Watcher is active
CH->>DB: Retrieve current block height from block store
DB-->>CH: Return block height
end
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)`**/*.go`: Review the Golang code for conformity with the Ub...
⏰ Context from checks skipped due to timeout of 90000ms (15)
🔇 Additional comments (2)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
tools/cosmovisor/go.mod(2 hunks)tools/cosmovisor/scanner.go(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.go`: Review the Golang code for conformity with the Ub...
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
tools/cosmovisor/scanner.go
⏰ Context from checks skipped due to timeout of 90000ms (26)
- GitHub Check: test-x-upgrade
- GitHub Check: test-x-tx
- GitHub Check: test-x-staking
- GitHub Check: test-x-slashing
- GitHub Check: test-x-protocolpool
- GitHub Check: test-x-nft
- GitHub Check: test-x-mint
- GitHub Check: test-x-group
- GitHub Check: test-x-gov
- GitHub Check: test-x-feegrant
- GitHub Check: test-x-evidence
- GitHub Check: test-x-epochs
- GitHub Check: test-x-distribution
- GitHub Check: test-x-consensus
- GitHub Check: test-x-circuit
- GitHub Check: test-sim-nondeterminism
- GitHub Check: test-simapp-v2
- GitHub Check: test-integration
- GitHub Check: test-cosmovisor
- GitHub Check: test-system-v2
- GitHub Check: build (arm64)
- GitHub Check: build (amd64)
- GitHub Check: Analyze
- GitHub Check: dependency-review
- GitHub Check: golangci-lint
- GitHub Check: Summary
🔇 Additional comments (2)
tools/cosmovisor/scanner.go (1)
79-86: LGTM! Well-implemented IsStop method.The method correctly implements a non-blocking channel check using select statement, which is the idiomatic way in Go to check if a channel is closed.
tools/cosmovisor/go.mod (1)
8-9: LGTM! Dependencies properly updated.The new direct dependencies align with the code changes in scanner.go, and the version updates are appropriate.
Also applies to: 120-120
|
Hey @zakir-code - could you target this against We will be maintaining |
zakir-code
force-pushed
the
zakir/check-height
branch
from
81ff378 to
b377562
Compare
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:Keys
github-actions
bot
removed
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:Keys
Hi @aljo242 I just read the report. It turns out that Cosmos has undergone such a big change recently. I look forward to the release of v0.53. |
Description
hi, @julienrbrt
When there is no
currentorcurrentis thegenesisversion, but thedatadirectory is an upgraded version (downloaded snapshot) and contains theupgrade-info.jsonfile, the node may not run normally due to the mismatch between thegenesisversion anddata, that is, the node cannot obtain the height throughstatusand cannot automatically upgrade current to the latest version.The problem is after #22528
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Chores
New Features