-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add textual support for unordered txs #23739
feat: add textual support for unordered txs #23739
Conversation
@technicallyty your pull request is missing a changelog! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic lgtm - is there any further logic that uses / populates these proto changes?
…echnicallyty/STA-122/sign_mode_textual_timeout
yep need to hold this for a sec, the x/tx proto changes didnt actually generate as a i thought |
…echnicallyty/STA-122/sign_mode_textual_timeout
…echnicallyty/STA-122/sign_mode_textual_timeout
…echnicallyty/STA-122/sign_mode_textual_timeout
…echnicallyty/STA-122/sign_mode_textual_timeout
266dbd6
into
technicallyty/STA-118/timeout_height_time_based
Description
adds textual support from commit: d7d5b15
ref: d7d5b15
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...