Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add textual support for unordered txs #23739

Conversation

technicallyty
Copy link
Contributor

Description

adds textual support from commit: d7d5b15

ref: d7d5b15


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@technicallyty technicallyty marked this pull request as ready for review February 22, 2025 01:25
@technicallyty technicallyty requested a review from a team as a code owner February 22, 2025 01:25
@technicallyty technicallyty changed the title add textual unordered stuff feat: add textual support for unordered txs Feb 22, 2025
Copy link
Contributor

@technicallyty your pull request is missing a changelog!

Copy link
Collaborator

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic lgtm - is there any further logic that uses / populates these proto changes?

…echnicallyty/STA-122/sign_mode_textual_timeout
@technicallyty
Copy link
Contributor Author

logic lgtm - is there any further logic that uses / populates these proto changes?

yep need to hold this for a sec, the x/tx proto changes didnt actually generate as a i thought

@technicallyty technicallyty marked this pull request as draft February 24, 2025 19:43
@technicallyty technicallyty marked this pull request as ready for review February 24, 2025 20:01
@aljo242 aljo242 linked an issue Feb 25, 2025 that may be closed by this pull request
@aljo242 aljo242 added this to the SDK v0.53 milestone Feb 25, 2025
…echnicallyty/STA-122/sign_mode_textual_timeout
@github-actions github-actions bot removed the C:x/auth label Feb 25, 2025
@technicallyty technicallyty merged commit 266dbd6 into technicallyty/STA-118/timeout_height_time_based Feb 25, 2025
54 checks passed
@technicallyty technicallyty deleted the technicallyty/STA-122/sign_mode_textual_timeout branch February 25, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Epic]: Unordered Tx support in v53
2 participants