-
Notifications
You must be signed in to change notification settings - Fork 89
feat: re-use tx validation rules from go-ethereum #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ante/evm/mono_decorator.go
Outdated
@@ -126,6 +151,7 @@ func (md MonoDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, ne | |||
// 5. signature verification | |||
if err := SignatureVerification( | |||
ethMsg, | |||
ethTx, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason for this, is ethTx
caches the sender recovery result, so we avoid duplicate signature verification efforts by reuse the object.
@yihuang can you please link an existing github issue for this? If one does not exist, feel free to create one. We want to ensure that all PRs have an associated issue for context. |
@yihuang this is good to go - just needs some test + lint fixes |
@yihuang conflicts |
Description
there are a few rules in go-ethereum tx validation function seems not covered, we can reuse it directly, some validations rules are overlapped, we can optimize later.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
main
branchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleased
section inCHANGELOG.md