Skip to content

Problem: query decimals get reverted when Display doesn't match with DenomUnit for ibc token #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 18, 2025

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Aug 4, 2025

Description

to avoid execution reverted when calling decimals from ibc dynamic precompile contract

Closes: #396


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@mmsqe mmsqe marked this pull request as ready for review August 4, 2025 11:45
@mmsqe mmsqe requested review from a team as code owners August 6, 2025 01:02
@vladjdk vladjdk self-assigned this Aug 11, 2025
@aljo242
Copy link
Contributor

aljo242 commented Aug 11, 2025

@mmsqe looks like we have a test consistently failing

@mmsqe
Copy link
Contributor Author

mmsqe commented Aug 11, 2025

@mmsqe looks like we have a test consistently failing

TestGetProposals seems flaky, seems not related to this change

@aljo242 aljo242 added the v0.5.x targeting v0.5.x label Aug 14, 2025
@vladjdk vladjdk enabled auto-merge August 14, 2025 23:48
@vladjdk vladjdk added this pull request to the merge queue Aug 18, 2025
Merged via the queue into cosmos:main with commit 810e9ef Aug 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.5.x targeting v0.5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: erc20 precompile for ibc token fail for decimals() call
3 participants