Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e): Add verbose logging to integration tests (#3580) #3584

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

MKVEERENDRA
Copy link

Adds test start logs (▶️ Starting test: XYZ...)
Adds test result logs (✅ PASSED / ❌ FAILED)
Improves debugging visibility for e2e tests

@MKVEERENDRA MKVEERENDRA requested a review from a team as a code owner March 1, 2025 07:46
@MKVEERENDRA
Copy link
Author

Updated the t *testing.T, testName string in line 32

Copy link
Contributor

@Eric-Warehime Eric-Warehime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Eric-Warehime Eric-Warehime self-assigned this Mar 3, 2025
fixed this error (untyped string constant) as *"testing"
@MKVEERENDRA
Copy link
Author

Fixed the (untyped string constant) for checks.

 Mark LogTestResult function as a test helper
@MKVEERENDRA
Copy link
Author

@Eric-Warehime my PR is still not merged

@vladjdk
Copy link
Member

vladjdk commented Mar 7, 2025

@Eric-Warehime my PR is still not merged

Please resolve the conflicts and then we'll trigger the workflows

@MKVEERENDRA
Copy link
Author

All the conflicts all solved @Eric-Warehime. Can you please verify it.

@vladjdk
Copy link
Member

vladjdk commented Mar 7, 2025

@MKVEERENDRA run a lint-fix on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants