Fix PFM to not fail packets that aren't FungibleTokenPacketData
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agouin
reviewed
Sep 28, 2023
assafmo
force-pushed
the
pfm-dont-fail-non-ics20-packets
branch
from
c32ab22
to
4165527
Compare
Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20). This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData. This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem
assafmo
force-pushed
the
pfm-dont-fail-non-ics20-packets
branch
from
4165527
to
8eed61d
Compare
agouin
approved these changes
Sep 28, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20). This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData. This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem (cherry picked from commit 39de938)
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20). This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData. This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem (cherry picked from commit 39de938)
This was referenced Sep 28, 2023
Merged
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20). This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData. This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem (cherry picked from commit 39de938)
jtieri
pushed a commit
that referenced
this pull request
Sep 28, 2023
#107) Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20). This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData. This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem (cherry picked from commit 39de938) Co-authored-by: Assaf Morami <[email protected]>
jtieri
pushed a commit
that referenced
this pull request
Sep 28, 2023
#106) Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20). This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData. This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem (cherry picked from commit 39de938) Co-authored-by: Assaf Morami <[email protected]>
jtieri
pushed a commit
that referenced
this pull request
Sep 28, 2023
#108) Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20). This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData. This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem (cherry picked from commit 39de938) Co-authored-by: Assaf Morami <[email protected]>
assafmo
added a commit
to scrtlabs/SecretNetwork
that referenced
this pull request
Oct 4, 2023
nicolaslara
added a commit
to osmosis-labs/osmosis
that referenced
this pull request
Oct 23, 2023
nicolaslara
added a commit
to osmosis-labs/osmosis
that referenced
this pull request
Oct 23, 2023
6 tasks
ValarDragon
pushed a commit
to osmosis-labs/osmosis
that referenced
this pull request
Oct 23, 2023
* use a version of pfm that inclides cosmos/ibc-apps#105 * lint
PaddyMc
pushed a commit
to osmosis-labs/osmosis
that referenced
this pull request
Oct 23, 2023
* use a version of pfm that inclides cosmos/ibc-apps#105 * lint
PaddyMc
pushed a commit
to osmosis-labs/osmosis
that referenced
this pull request
Oct 23, 2023
* use a version of pfm that inclides cosmos/ibc-apps#105 * lint
ValarDragon
pushed a commit
to osmosis-labs/osmosis
that referenced
this pull request
Oct 23, 2023
* use a version of pfm that inclides cosmos/ibc-apps#105 * lint
PaddyMc
added a commit
to osmosis-labs/osmosis
that referenced
this pull request
Nov 3, 2023
* Fix bad PFM error (#6734) * use a version of pfm that inclides cosmos/ibc-apps#105 * lint * chore: add changelog --------- Co-authored-by: Nicolas Lara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PFM fails packets that are not
FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively useFungibleTokenPacketDataas the payload format (i.e., ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement the ics20-* protocol (e.g., cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20).This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not
FungibleTokenPacketData.This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem