fix typo and improve docs

proto/interchain_security/ccv/provider/v1/tx.proto

@@ -8,7 +8,6 @@ import "gogoproto/gogo.proto";
 import "cosmos_proto/cosmos.proto";
 import "google/protobuf/any.proto";
 import "ibc/lightclients/tendermint/v1/tendermint.proto";
-import "tendermint/types/evidence.proto";
 
 // Msg defines the Msg service.
 service Msg {
@@ -46,10 +45,10 @@ message MsgRegisterConsumerRewardDenom {
 
 // MsgRegisterConsumerRewardDenomResponse defines the Msg/RegisterConsumerRewardDenom response type.
 message MsgRegisterConsumerRewardDenomResponse {}
-// MsgSubmitConsumerMisbehaviour reports a consumer chain Misbehaviour
 
 // MsgSubmitConsumerMisbehaviour defines a message that reports a misbehaviour
 // observed on a consumer chain
+// Note that the misbheaviour' headers must contain the same trusted states
 message MsgSubmitConsumerMisbehaviour {
   option (gogoproto.equal) = false;
   option (gogoproto.goproto_getters) = false;

tests/integration/misbehaviour.go

@@ -59,15 +59,15 @@ func (s *CCVTestSuite) TestHandleConsumerMisbehaviour() {
 
 	for _, v := range altValset.Validators {
 		consuAddr := sdk.ConsAddress(v.Address.Bytes())
-		provAddr := s.providerApp.GetProviderKeeper().GetProviderAddrFromConsumerAddr(s.providerCtx(), s.consumerChain.ChainID, types.ConsumerConsAddress{consuAddr})
+		provAddr := s.providerApp.GetProviderKeeper().GetProviderAddrFromConsumerAddr(s.providerCtx(), s.consumerChain.ChainID, types.NewConsumerConsAddress(consuAddr))
 		val, ok := s.providerApp.GetTestStakingKeeper().GetValidatorByConsAddr(s.providerCtx(), provAddr.Address)
 		s.Require().True(ok)
 		s.Require().True(val.Jailed)
 		s.Require().True(s.providerApp.GetTestSlashingKeeper().IsTombstoned(s.providerCtx(), provAddr.Address))
 	}
 }
 
-func (s *CCVTestSuite) TestConstructLigthClientEvidence() {
+func (s *CCVTestSuite) TestConstructLightClientEvidence() {
 	s.SetupCCVChannel(s.path)
 	// required to have the consumer client revision height greater than 0
 	s.SendEmptyVSCPacket()
@@ -208,7 +208,7 @@ func (s *CCVTestSuite) TestConstructLigthClientEvidence() {
 
 	for _, tc := range testCases {
 		s.Run(tc.name, func() {
-			ev, err := s.providerApp.GetProviderKeeper().ConstructLigthClientEvidence(
+			ev, err := s.providerApp.GetProviderKeeper().ConstructLightClientEvidence(
 				s.providerCtx(),
 				*tc.misbehaviour,
 			)

testutil/integration/debug_test.go

@@ -265,6 +265,6 @@ func TestHandleConsumerMisbehaviour(t *testing.T) {
 	runCCVTestByName(t, "TestHandleConsumerMisbehaviour")
 }
 
-func TestConstructLigthClientEvidence(t *testing.T) {
-	runCCVTestByName(t, "TestConstructLigthClientEvidence")
+func TestConstructLightClientEvidence(t *testing.T) {
+	runCCVTestByName(t, "TestConstructLightClientEvidence")
 }

x/ccv/provider/keeper/misbehaviour.go

@@ -13,7 +13,7 @@ import (
 )
 
 // HandleConsumerMisbehaviour checks whether the given IBC misbehaviour is valid and, if they are, the misbehaving
-// CheckConsumerMisbehaviour check that the given IBC misbehaviour headers forms a valid light client attck evidence.
+// CheckConsumerMisbehaviour check that the given IBC misbehaviour headers forms a valid light client attack evidence.
 // proceed to the jailing and tombstoning of the bzyantine validators.
 func (k Keeper) HandleConsumerMisbehaviour(ctx sdk.Context, misbehaviour ibctmtypes.Misbehaviour) error {
 	logger := ctx.Logger()
@@ -27,7 +27,7 @@ func (k Keeper) HandleConsumerMisbehaviour(ctx sdk.Context, misbehaviour ibctmty
 	// isn't too old. see ibc-go/modules/light-clients/07-tendermint/types/misbehaviour_handle.go
 
 	// construct a ligth client attack evidence
-	evidence, err := k.ConstructLigthClientEvidence(ctx, misbehaviour)
+	evidence, err := k.ConstructLightClientEvidence(ctx, misbehaviour)
 	if err != nil {
 		return err
 	}
@@ -36,7 +36,7 @@ func (k Keeper) HandleConsumerMisbehaviour(ctx sdk.Context, misbehaviour ibctmty
 	for _, v := range evidence.ByzantineValidators {
 		// convert consumer consensus address
 		consuAddr := sdk.ConsAddress(v.Address.Bytes())
-		provAddr := k.GetProviderAddrFromConsumerAddr(ctx, misbehaviour.Header1.Header.ChainID, types.ConsumerConsAddress{consuAddr})
+		provAddr := k.GetProviderAddrFromConsumerAddr(ctx, misbehaviour.Header1.Header.ChainID, types.NewConsumerConsAddress(consuAddr))
 		k.stakingKeeper.ValidatorByConsAddr(ctx, consuAddr)
 		val, ok := k.stakingKeeper.GetValidatorByConsAddr(ctx, provAddr.Address)
 
@@ -67,9 +67,9 @@ func (k Keeper) HandleConsumerMisbehaviour(ctx sdk.Context, misbehaviour ibctmty
 	return nil
 }
 
-// ConstructLigthClientEvidence constructs and returns a CometBFT Ligth Client Attack(LCA) evidence struct
+// ConstructLightClientEvidence constructs and returns a CometBFT Ligth Client Attack(LCA) evidence struct
 // from the given misbehaviour
-func (k Keeper) ConstructLigthClientEvidence(ctx sdk.Context, misbehaviour ibctmtypes.Misbehaviour) (*tmtypes.LightClientAttackEvidence, error) {
+func (k Keeper) ConstructLightClientEvidence(ctx sdk.Context, misbehaviour ibctmtypes.Misbehaviour) (*tmtypes.LightClientAttackEvidence, error) {
 
 	// construct the trusted and conflicetd ligth blocks
 	trusted, err := headerToLightBlock(*misbehaviour.Header1)

x/ccv/provider/types/codec.go

@@ -36,6 +36,11 @@ func RegisterInterfaces(registry codectypes.InterfaceRegistry) {
 		&EquivocationProposal{},
 	)
 
+	registry.RegisterImplementations(
+		(*sdk.Msg)(nil),
+		&MsgSubmitConsumerMisbehaviour{},
+	)
+
 	msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc)
 }