Skip to content

Commit

Permalink
addressed comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bermuell committed Sep 13, 2024
1 parent 01569ac commit adeb72b
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions tests/e2e/steps_permissionless_ics.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func stepsPermissionlessICS() []Step {
},
State: State{
ChainID("provi"): e2e.ChainState{
ConsumerChains: &map[ChainID]bool{"cons2": true}, // Consumer chain "consu1" is now removed
ConsumerChains: &map[ChainID]bool{"cons2": true},
},
},
},
Expand Down Expand Up @@ -167,7 +167,7 @@ func stepsPermissionlessICS() []Step {
ChainID("provi"): e2e.ChainState{
HasToValidate: &map[ValidatorID][]ChainID{
ValidatorID("alice"): {"cons1"},
ValidatorID("bob"): {"cons1"}, // bob is still a validator on consu chain
ValidatorID("bob"): {"cons1"}, // bob is still a validator on cons1 chain
ValidatorID("carol"): {},
},
},
Expand All @@ -185,9 +185,13 @@ func stepsPermissionlessICS() []Step {
State: State{
ChainID("provi"): e2e.ChainState{
ConsumerChains: &map[ChainID]bool{"cons2": true}, // Consumer chain "cons1" is now removed
// Note: current behavior is that the chain is enqueued for deletion and will be triggered
// when unbonding-period has passed.
// I't is still reported as a chain to be validated until it's finally deleted.
// This behaviour is currently discussed and might change.
HasToValidate: &map[ValidatorID][]ChainID{
ValidatorID("alice"): {"cons1"},
ValidatorID("bob"): {"cons1"}, // bob is still a validator on consu chain
ValidatorID("bob"): {"cons1"},
ValidatorID("carol"): {},
},
},
Expand Down

0 comments on commit adeb72b

Please sign in to comment.