cover stopped phase case

cosmos · Aug 26, 2024 · fca239b · fca239b
1 parent ad5288d
commit fca239b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/x/ccv/provider/keeper/grpc_query.go b/x/ccv/provider/keeper/grpc_query.go
@@ -352,9 +352,8 @@ func (k Keeper) QueryConsumerValidators(goCtx context.Context, req *types.QueryC
 		if err != nil {
 			return nil, status.Error(codes.Internal, err.Error())
 		}
-
-		//  if the consumer hasn't launched yet, compute the consumer validator set
-	} else {
+		//  if the consumer hasn't been launched being stopped, compute the consumer validator set
+	} else if phase != Stopped {
 		bondedValidators, err := k.GetLastBondedValidators(ctx)
 		if err != nil {
 			return nil, status.Error(codes.Internal, fmt.Sprintf("failed to get last validators: %s", err))

diff --git a/x/ccv/provider/keeper/grpc_query_test.go b/x/ccv/provider/keeper/grpc_query_test.go
@@ -282,6 +282,13 @@ func TestQueryConsumerValidators(t *testing.T) {
 	res, err = pk.QueryConsumerValidators(ctx, &req)
 	require.NoError(t, err)
 	require.Equal(t, val1.Commission.Rate, res.Validators[0].ConsumerCommissionRate)
+
+	// set consumer to stopped phase
+	pk.SetConsumerPhase(ctx, consumerId, keeper.Stopped)
+	// expect empty valset
+	res, err = pk.QueryConsumerValidators(ctx, &req)
+	require.NoError(t, err)
+	require.Empty(t, res)
 }
 
 func TestQueryConsumerChainsValidatorHasToValidate(t *testing.T) {