Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ADR-005 on cryptographic equivocation verifcation #1022

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Jun 15, 2023

Description

The slashing limitation of the upcoming ADR-005 requires some clarifications.

Closes: #1010


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct docs: prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR only changes documentation
  • Reviewed content for consistency
  • Reviewed content for spelling and grammar
  • Tested instructions (if applicable)
  • Checked that the documentation website can be built and deployed successfully (run make build-docs)

@sainoe sainoe marked this pull request as ready for review June 15, 2023 13:34
In a nutshell, consumer heights are mapped to provider heights through `VSCPackets`, namely through the so called `vscIDs`.
When an infraction occurs on the consumer, a `SlashPacket` containing the `vscID` obtained from mapping the consumer infraction height is sent to the provider.
Upon receiving the packet, the provider maps the consumer infraction height to a local infraction height, which is used to slash the misbehaving validator.
In the context of untrusted consumer chains, all their states, including `vscIDs`, could be corrupted and therefore cannot be used for slashing purposes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further, it would be ideal to completely eliminate the slash packets since we cannot trust them anyway.

@jtremback jtremback merged commit cba84d9 into jtremback-adr-005 Jun 16, 2023
@jtremback jtremback deleted the sainoe/adr-005 branch June 16, 2023 19:45
mpoke added a commit that referenced this pull request Aug 14, 2023
* Create adr-005-cryptographic-equivocation-verification.md

* docs: update ADR-005 on cryptographic equivocation verifcation (#1022)

* save first gist

* add first draft

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

---------

Co-authored-by: Marius Poke <[email protected]>

* docs: update cryptographic equivocation verification ADR (#1168)

* add first draft

* udpate refs

* update

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Marius Poke <[email protected]>

* add little changes

* address comments

* fix todos

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Anca Zamfir <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

Co-authored-by: Anca Zamfir <[email protected]>

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

* apply review suggestions

* Update docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

---------

Co-authored-by: Marius Poke <[email protected]>
Co-authored-by: Anca Zamfir <[email protected]>

* update intro.md

---------

Co-authored-by: Simon Noetzlin <[email protected]>
Co-authored-by: Marius Poke <[email protected]>
Co-authored-by: Anca Zamfir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants