Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: release notes template #1064

Merged
merged 6 commits into from
Jun 27, 2023
Merged

docs: release notes template #1064

merged 6 commits into from
Jun 27, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Jun 21, 2023

Description

Closes: NA

Add template for release notes and upgrading info.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct docs: prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR only changes documentation
  • Reviewed content for consistency
  • Reviewed content for spelling and grammar
  • Tested instructions (if applicable)
  • Checked that the documentation website can be built and deployed successfully (run make build-docs)

@mpoke mpoke requested a review from a team as a code owner June 21, 2023 21:39
UPGRADING.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do the trick.

Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that everyone should be pro-documentation. But we should be careful not to introduce extraneous documentation and processes that slow people down, or just make things hard to find. Staying lean is still important and there's a balance to be struck.

For example I think the info in UPGRADING.md could be included in existing docs like the changelog or release notes.


This guide provides instructions for upgrading to specific versions of Replicated Security.

## [v3.0.x](https://github.com/cosmos/interchain-security/releases/tag/v3.0.0-rc0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It should be https://github.com/cosmos/interchain-security/releases/tag/v3.0.0 once we cut v3.0.0. In the meantime, it's good to point to the release candidate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the text from v3.0.x to v3.0.0 then, but not a biggie

@@ -0,0 +1,27 @@
<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea that we'd copy/paste this into a release description, or does GH handle the template automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we add goreleaser to this repo, this file will act as input. See the release process on Gaia for more details https://github.com/cosmos/gaia/blob/main/RELEASE_PROCESS.md#release-notes

UPGRADING.md Show resolved Hide resolved
@mpoke
Copy link
Contributor Author

mpoke commented Jun 26, 2023

I understand that everyone should be pro-documentation. But we should be careful not to introduce extraneous documentation and processes that slow people down, or just make things hard to find. Staying lean is still important and there's a balance to be struck.

For example I think the info in UPGRADING.md could be included in existing docs like the changelog or release notes.

Thanks for the feedback @smarshall-spitzbart. The reason for this PR is to standardize our release process. Since the SDK repo is using this approach, I think it makes sense for the ICS repo to also adopt it. Note that the Gaia repo will also use this starting with v11.

Benefits of this approach:

@shaspitz
Copy link
Contributor

@mpoke all fair stuff, I agree with the benefits of this approach 👍. I think the info from UPGRADING.md is useful, but would be better in the RELEASE_NOTES.md to reduce the amount of mds we have to maintain

@mpoke mpoke merged commit fcb1ff4 into main Jun 27, 2023
@mpoke mpoke deleted the marius/release-template branch June 27, 2023 09:03
insumity pushed a commit that referenced this pull request Jul 24, 2023
* add release notes template

* add upgrading info

* add gh action to push proto files to buf.build

---------

Co-authored-by: MSalopek <[email protected]>
Co-authored-by: Shawn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants