-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: release notes template #1064
Conversation
.github/workflows/proto-registry.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should do the trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that everyone should be pro-documentation. But we should be careful not to introduce extraneous documentation and processes that slow people down, or just make things hard to find. Staying lean is still important and there's a balance to be struck.
For example I think the info in UPGRADING.md
could be included in existing docs like the changelog or release notes.
|
||
This guide provides instructions for upgrading to specific versions of Replicated Security. | ||
|
||
## [v3.0.x](https://github.com/cosmos/interchain-security/releases/tag/v3.0.0-rc0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this link to https://github.com/cosmos/interchain-security/tree/release/v3.0.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It should be https://github.com/cosmos/interchain-security/releases/tag/v3.0.0
once we cut v3.0.0. In the meantime, it's good to point to the release candidate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change the text from v3.0.x
to v3.0.0
then, but not a biggie
@@ -0,0 +1,27 @@ | |||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the idea that we'd copy/paste this into a release description, or does GH handle the template automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we add goreleaser to this repo, this file will act as input. See the release process on Gaia for more details https://github.com/cosmos/gaia/blob/main/RELEASE_PROCESS.md#release-notes
Thanks for the feedback @smarshall-spitzbart. The reason for this PR is to standardize our release process. Since the SDK repo is using this approach, I think it makes sense for the ICS repo to also adopt it. Note that the Gaia repo will also use this starting with v11. Benefits of this approach:
|
@mpoke all fair stuff, I agree with the benefits of this approach 👍. I think the info from |
* add release notes template * add upgrading info * add gh action to push proto files to buf.build --------- Co-authored-by: MSalopek <[email protected]> Co-authored-by: Shawn <[email protected]>
Description
Closes: NA
Add template for release notes and upgrading info.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:
prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:
prefix in the PR titlemake build-docs
)