Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix broken sovereign app.go #1068

Merged
merged 6 commits into from
Jun 23, 2023
Merged

tests: fix broken sovereign app.go #1068

merged 6 commits into from
Jun 23, 2023

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Jun 22, 2023

Description

Closes: #1070

Fix sovereign dummy chain app.go.

app.go was misconfigured:

  • some keys were missing
  • consusensusparams keeper not registered correctly
  • was using submit-proposal instead of submit-legacy-proposal for on chain upgrades

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@MSalopek MSalopek marked this pull request as ready for review June 22, 2023 17:42
@MSalopek MSalopek requested a review from a team as a code owner June 22, 2023 17:42
Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MSalopek MSalopek changed the title fix: fix broken sovereign app.go tests: fix broken sovereign app.go Jun 22, 2023
@mpoke mpoke merged commit 0339832 into main Jun 23, 2023
@mpoke mpoke deleted the masa/debug-sovereign-v47 branch June 23, 2023 08:06
mergify bot pushed a commit that referenced this pull request Jun 23, 2023
* fix: fix broken sovereign app.go

* chore: fix upgrade proposals for sovereign

* chore: fix sovereign app.go

* chore: re-enable all tests

* fix: update democ and throttle tests

(cherry picked from commit 0339832)
mpoke pushed a commit that referenced this pull request Jun 23, 2023
tests: fix broken sovereign app.go (#1068)

* fix: fix broken sovereign app.go

* chore: fix upgrade proposals for sovereign

* chore: fix sovereign app.go

* chore: re-enable all tests

* fix: update democ and throttle tests

(cherry picked from commit 0339832)

Co-authored-by: MSalopek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix problems with consumer changeover e2e tests
3 participants