-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
other: remove depguard and bump golangci-lint #1077
other: remove depguard and bump golangci-lint #1077
Conversation
To use the proper PR template: or if not using github you can copy/paste manually from https://github.com/cosmos/interchain-security/tree/main/.github/PULL_REQUEST_TEMPLATE |
See #990. We were having issues with the latest golangci-lint so we hardcoded a version that's functional |
@smarshall-spitzbart -- thanks very much for the preview tab link, I get where we're going with the templates now. This PR also hard-codes a version, the latest one (also functional) -- likely the thing that made it non-functional is that |
Tests not passing on this one |
@jtremback -- I think the tests pass? CI seems to say so Is there a test that ci isn't running? |
oh, there they are :) |
This doesn't change any files. @mpoke do you have any idea why it does not pass |
Description
This pull request removes the depguard linter, which suddenly started to work in an upgrade of golangci-lint and really isn't very useful in this setting. It also bumps golangci-lint to v1.5.3.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)CHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeI apologize because there is no preview tab when using
gh
and in fact I dont know which preview tab thisrefers to.
This PR removes depguard and bumps golangci-lint to
v1.53.3
Please go the the
Preview
tab and select the appropriate sub-template:fix
,feat
, andrefactor
.