Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

other: remove depguard and bump golangci-lint #1077

Merged
merged 6 commits into from
Aug 21, 2023
Merged

other: remove depguard and bump golangci-lint #1077

merged 6 commits into from
Aug 21, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 23, 2023 •
edited
Loading

Description

This pull request removes the depguard linter, which suddenly started to work in an upgrade of golangci-lint and really isn't very useful in this setting. It also bumps golangci-lint to v1.5.3.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

I apologize because there is no preview tab when using
gh and in fact I dont know which preview tab this
refers to.

This PR removes depguard and bumps golangci-lint to
v1.53.3

Please go the the Preview tab and select the appropriate sub-template:

  • Production code - for types fix, feat, and refactor.
  • Docs - for documentation changes.
  • Others - for changes that do not affect production code.

@faddat faddat requested a review from a team as a code owner June 23, 2023 12:05
@shaspitz
Copy link
Contributor

To use the proper PR template:
See
Screenshot 2023-06-23 at 11 18 48

or if not using github you can copy/paste manually from https://github.com/cosmos/interchain-security/tree/main/.github/PULL_REQUEST_TEMPLATE

@shaspitz
Copy link
Contributor

See #990. We were having issues with the latest golangci-lint so we hardcoded a version that's functional

@faddat
Copy link
Contributor Author

faddat commented Jun 25, 2023

@smarshall-spitzbart -- thanks very much for the preview tab link, I get where we're going with the templates now.

This PR also hard-codes a version, the latest one (also functional) -- likely the thing that made it non-functional is that depguard suddenly started working.

@faddat faddat changed the title chore: remove depguard and bump golangci-lint other: remove depguard and bump golangci-lint Jun 25, 2023
@jtremback
Copy link
Contributor

Tests not passing on this one

@faddat
Copy link
Contributor Author

faddat commented Aug 13, 2023 •
edited
Loading

@jtremback -- I think the tests pass?

CI seems to say so

Is there a test that ci isn't running?

@faddat
Copy link
Contributor Author

faddat commented Aug 13, 2023

oh, there they are :)

@faddat faddat marked this pull request as draft August 13, 2023 13:45
@faddat faddat marked this pull request as ready for review August 20, 2023 16:49
@github-actions github-actions bot added the C:CI Assigned automatically by the PR labeler label Aug 20, 2023
@faddat
Copy link
Contributor Author

faddat commented Aug 20, 2023

This doesn't change any files. @mpoke do you have any idea why it does not pass gosec?

@shaspitz shaspitz merged commit 653d29d into cosmos:main Aug 21, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaspitz shaspitz shaspitz approved these changes

@mpoke mpoke mpoke approved these changes

Assignees
No one assigned
Labels
C:CI Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faddat @shaspitz @jtremback @mpoke