Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump hermes to v1.8.0 #1079

Merged
merged 20 commits into from
Feb 21, 2024
Merged

chore: bump hermes to v1.8.0 #1079

merged 20 commits into from
Feb 21, 2024

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 25, 2023

Description

Works on issue:

This PR updates hermes to v1.7.4 and ensures that hermes is not using a feature branch fork.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@faddat faddat requested a review from a team as a code owner June 25, 2023 04:11
@faddat faddat changed the title bump: hermes v1.5.1 other: hermes v1.5.1 Jun 25, 2023
@faddat faddat marked this pull request as draft June 25, 2023 05:40
@faddat faddat marked this pull request as ready for review July 3, 2023 10:10
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@faddat
Copy link
Contributor Author

faddat commented Aug 13, 2023

@jtremback those changes happened because of changes in the docker image used.

@github-actions github-actions bot added the C:Build Assigned automatically by the PR labeler label Aug 17, 2023
@faddat
Copy link
Contributor Author

faddat commented Aug 20, 2023

@jtremback I'm going to flip this back to a draft, I have to update the configuration used for Hermes because I've now updated this to v1.6.0

@faddat faddat marked this pull request as draft August 20, 2023 16:46
@faddat faddat changed the title other: hermes v1.5.1 other: hermes v1.6.0 Sep 16, 2023
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Sep 16, 2023
@faddat faddat marked this pull request as ready for review September 16, 2023 04:37
@faddat
Copy link
Contributor Author

faddat commented Sep 16, 2023

@jtremback - I think that the remaining issue, may be related to either the new relayer software, or test code, and I also think that it may work fine on a second run.

@faddat faddat changed the title other: hermes v1.6.0 deps: hermes v1.6.0 Dec 29, 2023
@faddat faddat changed the title deps: hermes v1.6.0 chore: hermes v1.6.0 Dec 29, 2023
@mpoke mpoke changed the title chore: hermes v1.6.0 chore: bump hermes to v1.7.4 Jan 4, 2024
Dockerfile.gaia Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faddat
Copy link
Contributor Author

faddat commented Feb 10, 2024

maybe

@faddat faddat changed the title chore: bump hermes to v1.7.4 chore: bump hermes to v1.8.0 Feb 10, 2024
@mpoke mpoke added this pull request to the merge queue Feb 21, 2024
Merged via the queue into cosmos:main with commit c2a7b57 Feb 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Build Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants