Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate containers to informalsystems repos #1172

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

p-offtermatt
Copy link
Contributor

@p-offtermatt p-offtermatt commented Aug 1, 2023

Description

Closes: #1016

This PR removes the dependencies in the Dockerfile that point to my personal Dockerhub account.
Instead, the containers are now in the github container registry.
They are also tagged by version, so that it is easier to tell with what version the images are compatible.

The change in the start-chain script is to work with this new version of CometMock, where
the abci transport medium can now be chosen between grpc and socket, thus the command now has grpc as its last argument.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@p-offtermatt p-offtermatt requested a review from a team as a code owner August 1, 2023 07:07
@p-offtermatt p-offtermatt linked an issue Aug 1, 2023 that may be closed by this pull request
@p-offtermatt p-offtermatt changed the title chore: Migrate containers to informalsystems repos and fix versions chore: Migrate containers to informalsystems repos Aug 1, 2023
@MSalopek MSalopek merged commit c496513 into main Aug 2, 2023
10 checks passed
@MSalopek MSalopek deleted the ph/container-migration branch August 2, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Move dependencies away from personal dockerhub
3 participants