Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix mismatching code/comment and use WaitTime instead of sleep #1174

Merged

Conversation

p-offtermatt
Copy link
Contributor

Description

Closes: #1173

  • Adjust the comment to match the intended behaviour of waiting the downtime_jail_duration
  • Use the WaitTime function instead of sleeping

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@p-offtermatt p-offtermatt requested a review from a team as a code owner August 1, 2023 08:15
@p-offtermatt p-offtermatt linked an issue Aug 1, 2023 that may be closed by this pull request
5 tasks
@p-offtermatt p-offtermatt changed the title test: Fix mismatching comment and use WaitTime instead of sleep test: Fix mismatching code/comment and use WaitTime instead of sleep Aug 1, 2023
@p-offtermatt p-offtermatt merged commit 5e5e2fa into main Aug 1, 2023
10 checks passed
@p-offtermatt p-offtermatt deleted the ph/1173-mismatching-commentcode-in-unjailvalidator branch August 1, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatching comment/code in unjailValidator
3 participants