test: reduce number of happyPath steps #1179
Conversation
| stepsDoubleSignOnProviderAndConsumer("consu"), // carol double signs on provider, bob double signs on consumer | ||
| stepsSubmitEquivocationProposal("consu", 2), // now prop to tombstone bob is submitted and accepted | ||
| stepsStartRelayer(), | ||
| stepsConsumerRemovalPropNotPassing("consu", 3), // submit removal prop but vote no on it - chain should stay |
There was a problem hiding this comment.
Checked in shortHappyPathSteps
There was a problem hiding this comment.
When is the short happy path executed?
My understanding is that the normal happy path is executed during CI (e.g., automated tests before we merge), but not clear about the short happy_ path.
There was a problem hiding this comment.
It's a misnomer. short uses cometmock but it is not running in CI yet
| @@ -22,13 +22,9 @@ var happyPathSteps = concatSteps( | |||
| stepsRedelegateForOptOut("consu"), | |||
| stepsDowntimeWithOptOut("consu"), | |||
| stepsRedelegate("consu"), | |||
| stepsDowntime("consu"), | |||
There was a problem hiding this comment.
No need to test for downtime twice, testing for downtime with soft opt-out also covers "normal" downtime.
There was a problem hiding this comment.
Although both use the downtimeSlashAction action, in stepsDowntimeWithOptOut there doesn't seem that slashing takes place since alice has < 5% of the total voting power. While in stepsDowntime, bob is indeed slashed.
Additionally stepsDowntime is also performing an unjailValidatorAction.
Therefore, wouldn't we weaken the happyPathSteps by removing the stepsDowntime?
There was a problem hiding this comment.
It will, but there's an additional issue that proposes changes to how this runs in the CI:
We can have multiple jobs running in parallel and make the execution time shorter
| @@ -21,7 +21,7 @@ func stepsRejectEquivocationProposal(consumerName string, propNumber uint) []Ste | |||
| ValPowers: &map[validatorID]uint{ | |||
| validatorID("alice"): 509, | |||
| validatorID("bob"): 500, | |||
| validatorID("carol"): 495, | |||
| validatorID("carol"): 501, | |||
There was a problem hiding this comment.
Why were the voting powers changed here?
There was a problem hiding this comment.
Some steps that changed the voting power were removed. Steps are executed sequentially, so if you remove one of them you have to account for the removal in other places.
MSalopek
force-pushed
the
masa/1178-happy-path-cleanup
branch
from
1c9771f
to
5457e71
Compare
|
Setting this back to draft. A better approach was chosen. We can do this later, the current approach is to add cometmock first |
Description
Closes: #1178
Attempt to reduce the number of steps in e2e happy path to reduce CI runtimes.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...