Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix failing e2e test #1186

Merged
merged 4 commits into from
Aug 9, 2023
Merged

test: Fix failing e2e test #1186

merged 4 commits into from
Aug 9, 2023

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Aug 7, 2023

Description

Closes: #1167

This PR fixes an error in the e2e test.
When running e2e tests

  • tests did not check expected error condition in assignConsumerPubKey
  • transaction command to assign consensus key did not return error until '--gas auto' option was provided

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@bermuell bermuell force-pushed the bernd/1167-test-e2e-failure branch from d2d9459 to 1c4e0d4 Compare August 7, 2023 15:43
@bermuell bermuell marked this pull request as ready for review August 8, 2023 06:05
@bermuell bermuell requested a review from a team as a code owner August 8, 2023 06:05
@MSalopek MSalopek changed the title Test: Fix failing e2e test test: Fix failing e2e test Aug 8, 2023
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the suggested comment - it will print out the err and the response.

Approve!

tests/e2e/actions.go Outdated Show resolved Hide resolved
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this!
If you want, you could dive into why this needs gas auto, investigating this might be an admittedly rough way to dive deeper into the Cosmos SDK. I think it's not strictly necessary and I'd be happy with the current state, too.

tests/e2e/actions.go Outdated Show resolved Hide resolved
tests/e2e/actions.go Show resolved Hide resolved
@p-offtermatt
Copy link
Contributor

Thanks for addressing my comments, feel free to merge

@MSalopek MSalopek merged commit 3f4c54c into main Aug 9, 2023
10 checks passed
@MSalopek MSalopek deleted the bernd/1167-test-e2e-failure branch August 9, 2023 09:43
bermuell added a commit that referenced this pull request Nov 30, 2023
* Tests: Fix failing e2e tests

* Update tests/e2e/actions.go

Co-authored-by: MSalopek <[email protected]>

* chore: appease lint rules

* added check error message

---------

Co-authored-by: MSalopek <[email protected]>
bermuell added a commit that referenced this pull request Dec 1, 2023
* Tests: Fix failing e2e tests

* Update tests/e2e/actions.go

Co-authored-by: MSalopek <[email protected]>

* chore: appease lint rules

* added check error message

---------

Co-authored-by: MSalopek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e tests fail with --verbose
3 participants