Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for queryProviderInfo #1189

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

yaruwangway
Copy link
Contributor

@yaruwangway yaruwangway commented Aug 9, 2023

Description

Closes: #XXXX

Add test for this merged PR. #1164


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@yaruwangway yaruwangway marked this pull request as ready for review October 4, 2023 09:05
@yaruwangway yaruwangway requested a review from a team as a code owner October 4, 2023 09:05
@sainoe sainoe self-requested a review October 4, 2023 12:59
@p-offtermatt p-offtermatt merged commit 9f04ca6 into main Oct 11, 2023
12 checks passed
@p-offtermatt p-offtermatt deleted the provider-info-query-test branch October 11, 2023 13:06
MSalopek pushed a commit that referenced this pull request Dec 1, 2023
* test: add test for queryProviderInfo

* chore: correct typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants