Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: 1175 ci refactor e2e #1191

Merged
merged 13 commits into from
Aug 11, 2023
Merged

Tests: 1175 ci refactor e2e #1191

merged 13 commits into from
Aug 11, 2023

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Aug 9, 2023

Description

Closes: #1175

  • Created github workflow e2e tests
  • changed e2e tests for easier test selection (see -tc argument)
  • dedicated jobs for each e2e test case on manual and nightly workflow

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@bermuell bermuell force-pushed the bernd/1175-CI-refactor-e2e branch 4 times, most recently from cd25467 to fd52603 Compare August 10, 2023 13:25
@bermuell bermuell marked this pull request as ready for review August 10, 2023 13:47
@bermuell bermuell requested a review from a team as a code owner August 10, 2023 13:47
tests/e2e/steps.go Outdated Show resolved Hide resolved
.github/workflows/manual-e2e.yml Show resolved Hide resolved
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval!

Thanks for spending the time to refactor this!

@shaspitz
Copy link
Contributor

My understanding is that the changed files manual-e2e.yml and nightly-e2e.yml are not used for CI. Rather automated-tests.yml is used for CI. The issue seems to mention improving CI reporting, which would be unchanged by this PR due to automated-tests.yml being unchanged. Am I misunderstanding something here?

@bermuell
Copy link
Contributor Author

bermuell commented Aug 11, 2023

My understanding is that the changed files manual-e2e.yml and nightly-e2e.yml are not used for CI. Rather automated-tests.yml is used for CI. The issue seems to mention improving CI reporting, which would be unchanged by this PR due to automated-tests.yml being unchanged. Am I misunderstanding something here?

Reason is that the changes forseen for the automated tests (splitting E2E from UT, IT) were addressed by PR #1181 and introduction of cometmock based tests changed the need for splitting happy path test in respect of downtime (normal vs throttling).

The old docstring was outdated and since modified on main
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pushed one change to the docstring of the short happy path.

I also think we might want to rename the short happy path to cometmock-happy-path or something like this, since it's getting longer and really the main distinction is that it avoids things incompatible with cometmock specifically. But this is not really that important imo, so I'm happy with this as-is, too

@bermuell bermuell merged commit 64d860d into main Aug 11, 2023
12 checks passed
@bermuell bermuell deleted the bernd/1175-CI-refactor-e2e branch August 11, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: refactor how e2e tests are run in github actions
4 participants