-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: 1175 ci refactor e2e #1191
Conversation
b28e1d5
to
b4de586
Compare
41bdab7
to
21ed133
Compare
This reverts commit b4de586.
cd25467
to
fd52603
Compare
fd52603
to
7f2ac85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval!
Thanks for spending the time to refactor this!
My understanding is that the changed files |
Reason is that the changes forseen for the automated tests (splitting E2E from UT, IT) were addressed by PR #1181 and introduction of cometmock based tests changed the need for splitting happy path test in respect of downtime (normal vs throttling). |
The old docstring was outdated and since modified on main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I pushed one change to the docstring of the short happy path.
I also think we might want to rename the short happy path to cometmock-happy-path or something like this, since it's getting longer and really the main distinction is that it avoids things incompatible with cometmock specifically. But this is not really that important imo, so I'm happy with this as-is, too
Description
Closes: #1175
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...