Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add upgrade note for v4 and increment consumer consensus version #1201

Closed
wants to merge 2 commits into from
Closed

fix: add upgrade note for v4 and increment consumer consensus version #1201

wants to merge 2 commits into from

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Aug 14, 2023 •
edited
Loading

Description

Part of #1198

  • Adds note on v4 upgrade requiring migrations
  • Increments consumer consensus version number
  • Updates changelog in main

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@shaspitz shaspitz marked this pull request as ready for review August 14, 2023 17:24
@shaspitz shaspitz requested a review from a team as a code owner August 14, 2023 17:24
p-offtermatt
p-offtermatt approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question about the link but otherwise looks solid

UPGRADING.md
@@ -62,12 +62,6 @@ import (
)
```

## [v2.0.x](https://github.com/cosmos/interchain-security/releases/tag/v2.0.0)
## [v4.0.x](https://github.com/cosmos/interchain-security/tree/release%2Fv4.0.x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right link? Just wondering since the old link was to a release, this is just to the repo root for the commit.

mpoke
mpoke requested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest closing this PR as we don't need to jump to v4 yet.

@shaspitz shaspitz closed this Aug 17, 2023
@shaspitz shaspitz deleted the shawn/v4-upgrade-smalls branch August 17, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke mpoke requested changes

@p-offtermatt p-offtermatt p-offtermatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaspitz @mpoke @p-offtermatt