feat: implement slashing functionality on the provider chain (ADR-013) #1275

insumity · 2023-09-07T15:38:40Z

Description

Closes: #1274

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage

x/ccv/provider/keeper/double_vote.go

x/ccv/provider/keeper/punish_validator.go

x/ccv/types/expected_keepers.go

x/ccv/provider/keeper/double_vote.go

x/ccv/provider/keeper/misbehaviour.go

x/ccv/provider/keeper/punish_validator.go

insumity · 2023-09-12T13:31:27Z

tests/e2e/steps_consumer_misbehaviour.go

@@ -230,6 +230,10 @@ func stepsCauseConsumerMisbehaviour(consumerName string) []Step {
 						validatorID("alice"): 511,
 						validatorID("bob"):   20,
 					},
+					RepresentativePowers: &map[validatorID]uint{


Using RepresentativePowers was the only way I found to verify that slashing indeed takes place.
Using ValPowers was not useful because after a validator gets jailed, the validator's voting power is 0. I also could not unjail and then check ValPowers similarly to what is done in steps_multi_consumer_downtime.go because in contrast to a downtime test, for misbehaviour & equivocation we also we also tombstone the validator.

Seems ok to me. Could rename it to something like StakedTokens instead of RepresentativePowers (looking at the code, I think that's what this actually is, right?)

* feat!: add ICS misbehaviour handling (#826) * define msg to submit misbehaviour to provider implement msg handling logic e2e test msg handling logic * wip: get byzantine validators in misbehavioiur handling * add tx handler * format HandleConsumerMisbehaviour * add tx handler * add debugging stuff * Add misbehaviour handler * create message for consumer double voting evidence * add DRAFT double vote handler * Add cli cmd for submit consumer double voting * Add double-vote handler * add last update * fix jailing * pass first jailing integration test * format tests * doc * save * update e2e tests' * fix typo and improve docs * remove unwanted tm evidence protofile * fix typos * update submit-consumer-misbehaviour cli description * check that header1 and header2 have the same TrustedValidators * feat: add e2e tests for ICS misbehaviour (#1118) * remove unwanted changes * fix hermes config with assigned key * revert unwanted changes * revert local setup * remove log file * typo * update doc * update ICS misbehaviour test * update ICS misbehaviour test * revert mixed commits * add doc * lint * update to handle only equivocations * improve doc * update doc * update E2E tests comment * optimize signatures check * doc * update e2e tests * linter * remove todo * Feat: avoid race condition in ICS misbehaviour handling (#1148) * remove unwanted changes * fix hermes config with assigned key * revert unwanted changes * revert local setup * remove log file * typo * update doc * update ICS misbehaviour test * update ICS misbehaviour test * revert mixed commits * update ICS misbehaviour test * update ICS misbehaviour test * Add test for MsgSubmitConsumerMisbehaviour parsing * fix linter * save progress * add CheckMisbehaviourAndUpdateState * update integration tests * typo * remove e2e tests from another PRs * cleaning' * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * update integration tests * save * save * nits * remove todo * lint * Update x/ccv/provider/keeper/misbehaviour.go --------- Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Marius Poke <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: Anca Zamfir <[email protected]> * add attributes to EventTypeSubmitConsumerMisbehaviour * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * apply review suggestions * fix docstring * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * fix link * apply review suggestions * update docstring --------- Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Marius Poke <[email protected]> * feat: improve ICS misbehaviour E2E testing coverage (#1225) * update e2e tests * update the chain halt assertion * refactor: address comments of ICS Misbehaviour PRs #826 and #1148 (#1223) * remove interface * improve comment * update godoc * address last comments * feat: add handler for consumer double voting (#1232) * create new endpoint for consumer double voting * add first draft handling logic * first iteration of double voting * draft first mem test * error handling * refactor * add unit test of double voting verification * remove evidence age checks * document * doc * protogen * reformat double voting handling * logger nit * nits * check evidence age duration * move verify double voting evidence to ut * fix nit * nits * fix e2e tests * improve double vote testing coverage * remove TODO * lint * add UT for JailAndTombstoneValidator * nits * nits * remove tombstoning and evidence age check * lint * typo * improve godoc * fix: tiny bug in `NewSubmitConsumerDoubleVotingCmd` (#1247) * fix double voting cli * fix bug double signing handler * godoc * nits * revert wrong push of lasts commits * fix: make `HandleConsumerDoubleVoting` works with provider pubkeys (#1254) * fix double voting cli * fix bug double signing handler * godoc * nits * lint * nit * fix: verify equivocation using validator pubkey in `SubmitConsumerDoubleVoting` msg (#1264) * verify dv evidence using malicious validator pubkey in infraction block header * nits * nits * refactor: update the E2E tests to work with Hermes relayer v1.6.0 (#1278) * save changes * fix hermes config * fist successful run * nit * nits * nits * doc and nits * lint * test: add E2E tests for double voting evidence handling (#1256) * fix double voting cli * add double-signing e2e test * refortmat e2e double voting test * godoc, revert unwanted changes * nit * verify dv evidence using malicious validator pubkey in infraction block header * save changes * fix hermes config * fist successful run * nit * nits * nits * doc and nits * lint * refactor * typo * change hermes docker image * nits * Update tests/e2e/steps.go Co-authored-by: Philip Offtermatt <[email protected]> * address PR comments * nits --------- Co-authored-by: Philip Offtermatt <[email protected]> * save * fix nits * update changelog and fix nits --------- Co-authored-by: Simon Noetzlin <[email protected]> Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]>

x/ccv/provider/keeper/misbehaviour.go

x/ccv/provider/keeper/punish_validator.go

…mpl-on-feat

insumity · 2023-09-22T11:26:00Z

docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md

@@ -0,0 +1,105 @@
+---


cherry picked this file so markdown link checker doesn't complain.

sainoe · 2023-09-22T15:13:48Z

Nice work!

mpoke

See my comments below.

mpoke · 2023-09-25T15:37:01Z

x/ccv/provider/keeper/punish_validator.go

 	logger := k.Logger(ctx)

 	// get validator
 	val, ok := k.stakingKeeper.GetValidatorByConsAddr(ctx, providerAddr.ToSdkConsAddr())
 	if !ok || val.IsUnbonded() {
-		logger.Error("validator not found or is unbonded", providerAddr.String())
+		logger.Error("validator not found or is unbonded", "provider consensus address", providerAddr.String())
 		return


Why don't we return the error. Both calls to this function happens on deliverTx, so we can handle the error.

Good point. Fixed it and we return the error instead.

Found the relevant ErrNoValidatorForAddress error for this one. For others, I couldn't find a relevant error in cosmos-sdk I ended up doing fmt.Errorf to creat errors.

x/ccv/provider/keeper/punish_validator.go

mpoke · 2023-09-25T16:12:13Z

x/ccv/provider/keeper/punish_validator.go

+	}
+
+	// compute the total numbers of tokens currently being redelegated
+	redelegationsInTokens := sdk.NewInt(0)


nit: We can use the same variable from above (e.g., undelegationsInTokens) and avoid the addition below.

mpoke

Nice work @insumity

p-offtermatt

Partial review. I think the subtlety in ComputePowerToSlash should be addressed, this is a bit tricky imo and we can improve it with more comments and/or splitting out some logic.

x/ccv/provider/keeper/punish_validator.go

p-offtermatt · 2023-09-26T08:02:50Z

x/ccv/provider/keeper/punish_validator.go

+	// compute the total numbers of tokens currently being undelegated
+	undelegationsInTokens := sdk.NewInt(0)
+
+	cachedCtx, _ := ctx.CacheContext()


Maybe instead of using this cached context here (or in addition to this), we could have wraps for SlashUnbondingDelegation and SlashRedelegation that just call those on cached contexts and call the wraps e.g. ComputeUnbondingDelegationPower - it's very subtle with the cached context and the slash factor of 1 here

x/ccv/provider/keeper/punish_validator_test.go

p-offtermatt · 2023-09-26T08:09:27Z

tests/e2e/steps_consumer_misbehaviour.go

@@ -230,6 +230,10 @@ func stepsCauseConsumerMisbehaviour(consumerName string) []Step {
 						validatorID("alice"): 511,
 						validatorID("bob"):   20,
 					},
+					RepresentativePowers: &map[validatorID]uint{


Seems ok to me. Could rename it to something like StakedTokens instead of RepresentativePowers (looking at the code, I think that's what this actually is, right?)

p-offtermatt

Thanks, the changes look great! Approving

* feat!: add ICS misbehaviour handling (#826) * define msg to submit misbehaviour to provider implement msg handling logic e2e test msg handling logic * wip: get byzantine validators in misbehavioiur handling * add tx handler * format HandleConsumerMisbehaviour * add tx handler * add debugging stuff * Add misbehaviour handler * create message for consumer double voting evidence * add DRAFT double vote handler * Add cli cmd for submit consumer double voting * Add double-vote handler * add last update * fix jailing * pass first jailing integration test * format tests * doc * save * update e2e tests' * fix typo and improve docs * remove unwanted tm evidence protofile * fix typos * update submit-consumer-misbehaviour cli description * check that header1 and header2 have the same TrustedValidators * feat: add e2e tests for ICS misbehaviour (#1118) * remove unwanted changes * fix hermes config with assigned key * revert unwanted changes * revert local setup * remove log file * typo * update doc * update ICS misbehaviour test * update ICS misbehaviour test * revert mixed commits * add doc * lint * update to handle only equivocations * improve doc * update doc * update E2E tests comment * optimize signatures check * doc * update e2e tests * linter * remove todo * Feat: avoid race condition in ICS misbehaviour handling (#1148) * remove unwanted changes * fix hermes config with assigned key * revert unwanted changes * revert local setup * remove log file * typo * update doc * update ICS misbehaviour test * update ICS misbehaviour test * revert mixed commits * update ICS misbehaviour test * update ICS misbehaviour test * Add test for MsgSubmitConsumerMisbehaviour parsing * fix linter * save progress * add CheckMisbehaviourAndUpdateState * update integration tests * typo * remove e2e tests from another PRs * cleaning' * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * update integration tests * save * save * nits * remove todo * lint * Update x/ccv/provider/keeper/misbehaviour.go --------- Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Marius Poke <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: Anca Zamfir <[email protected]> * add attributes to EventTypeSubmitConsumerMisbehaviour * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * apply review suggestions * fix docstring * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * fix link * apply review suggestions * update docstring --------- Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Marius Poke <[email protected]> * feat: improve ICS misbehaviour E2E testing coverage (#1225) * update e2e tests * update the chain halt assertion * refactor: address comments of ICS Misbehaviour PRs #826 and #1148 (#1223) * remove interface * improve comment * update godoc * address last comments * feat: add handler for consumer double voting (#1232) * create new endpoint for consumer double voting * add first draft handling logic * first iteration of double voting * draft first mem test * error handling * refactor * add unit test of double voting verification * remove evidence age checks * document * doc * protogen * reformat double voting handling * logger nit * nits * check evidence age duration * move verify double voting evidence to ut * fix nit * nits * fix e2e tests * improve double vote testing coverage * remove TODO * lint * add UT for JailAndTombstoneValidator * nits * nits * remove tombstoning and evidence age check * lint * typo * improve godoc * fix: tiny bug in `NewSubmitConsumerDoubleVotingCmd` (#1247) * fix double voting cli * fix bug double signing handler * godoc * nits * revert wrong push of lasts commits * fix: make `HandleConsumerDoubleVoting` works with provider pubkeys (#1254) * fix double voting cli * fix bug double signing handler * godoc * nits * lint * nit * fix: verify equivocation using validator pubkey in `SubmitConsumerDoubleVoting` msg (#1264) * verify dv evidence using malicious validator pubkey in infraction block header * nits * nits * refactor: update the E2E tests to work with Hermes relayer v1.6.0 (#1278) * save changes * fix hermes config * fist successful run * nit * nits * nits * doc and nits * lint * test: add E2E tests for double voting evidence handling (#1256) * fix double voting cli * add double-signing e2e test * refortmat e2e double voting test * godoc, revert unwanted changes * nit * verify dv evidence using malicious validator pubkey in infraction block header * save changes * fix hermes config * fist successful run * nit * nits * nits * doc and nits * lint * refactor * typo * change hermes docker image * nits * Update tests/e2e/steps.go Co-authored-by: Philip Offtermatt <[email protected]> * address PR comments * nits --------- Co-authored-by: Philip Offtermatt <[email protected]> * feat!: provider proposal for changing reward denoms (backport #1280) (#1291) * feat!: provider proposal for changing reward denoms (#1280) * new provider prop type * add methods and tests for new prop, update docs * remove old tx, fix tests * e2e handling * fix command type * boilerplate * fix e2e tests * Update CHANGELOG.md * lint * validate denoms * Update proposal.go * rm msg string * fix tests * rm chain in change denom action * lint * test for invalid denom * events for both add and remove * Update proposal_test.go (cherry picked from commit 48a2186) # Conflicts: # CHANGELOG.md # app/provider/app.go # proto/interchain_security/ccv/provider/v1/provider.proto # proto/interchain_security/ccv/provider/v1/tx.proto # tests/e2e/actions.go # tests/integration/distribution.go # x/ccv/provider/client/cli/tx.go # x/ccv/provider/client/proposal_handler.go # x/ccv/provider/keeper/distribution.go # x/ccv/provider/keeper/distribution_test.go # x/ccv/provider/proposal_handler_test.go # x/ccv/provider/types/codec.go # x/ccv/provider/types/proposal.go # x/ccv/provider/types/provider.pb.go # x/ccv/provider/types/tx.pb.go * fix conflicts * fix rest handler * Update CHANGELOG.md * rm uneeded tx proto --------- Co-authored-by: Shawn <[email protected]> * save * fix nits * update changelog and fix nits * feat: implement slashing functionality on the provider chain (ADR-013) (#1275) Implementing the slashing functionality, as described in ADDR, on the provider chain. * remove equivocation proposal * bring back evidencekeeper * go.sum added * rebase and fix lint issues * fix mocks * clean up protos & delete unecessary file * fix E2E test * fix Dockerfile * more fixes * increase wait attempt * increase wait attempt * wait 1 block in gov proposal * fix numbers * fix double voting security hole * fix error logging * fix nit * fix first comments * add hermes comment * update changelog * changes misbehavour logging * update double vote and mem test * change misb error flow * add debug call * add redelegations testings * fix nit in mem test * add comment --------- Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Marius Poke <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Shawn <[email protected]> Co-authored-by: insumity <[email protected]> Co-authored-by: Karolos Antoniadis <[email protected]>

@MSalopek

* docs: cleanup changelog for v2.0.0 on release/v2.0.x (#987) * Update CHANGELOG.md * Update CHANGELOG.md * comment * chore: Hardcode golangci-lint version (backport #990) (#1013) chore: Hardcode golangci-lint version (#990) * Hardcode golangci-lint version * Hardcode version in CI config (cherry picked from commit 9920121) Co-authored-by: Philip Offtermatt <[email protected]> * fix: proper consumer key prefix ordering (backport #991) (#1011) fix: proper consumer key prefix ordering (#991) * Update keys.go * tests * fix another bug * fix comments (cherry picked from commit a1e18d0) Co-authored-by: Shawn <[email protected]> * feat: Remove consumer genesis migration on provider (backport #997) (#1012) feat: Remove consumer genesis migration on provider (#997) * Update keys.go * tests * fix another bug * remove consumer genesis deletion, link to test * remove unused bond denom method * Revert "remove unused bond denom method" This reverts commit f930eca. * remove test too * update changelog (cherry picked from commit e2ac974) Co-authored-by: Shawn <[email protected]> * fix: limit vsc matured packets handled per endblocker (backport #1004) (#1015) fix: limit vsc matured packets handled per endblocker (#1004) * initial implementation, still need tests * UTs * integration test * linter * Update CHANGELOG.md * make vsc matured handled this block a var * comment (cherry picked from commit 8c2fc56) Co-authored-by: Shawn <[email protected]> * feat: integrate cometmock (backport #989) (#1030) feat: integrate cometmock (#989) * Add gorelayer and CometMock to Dockerfile * Add option to start with cometmock in start-chain script * Start adding support for rly * Adjust relayer start action * Add entrypoint for short happy path steps * Add . nosec G204 and waiting for blocks * Adjust rly config: Gas is free * Remove optout steps from short happy path * Use separate redelegate step for short happy path * Wait for blocks after unbonding * Make naming more descriptive and add comments * Add comment to chain name sorting and improve comments * Update start-chain.sh Address comments form joint review session with @MSalopek * Fix typo (cherry picked from commit 07be71a) Co-authored-by: Philip Offtermatt <[email protected]> * feat!: Add DistributionTransmissionChannel to ConsumerAdditionProposal (manual backport #965) (#1031) feat!: Add DistributionTransmissionChannel to ConsumerAdditionProposal (#965) * update proto * remove transfer_channel_id from consumer genesis * ConsumerAdditionProposal: transfer_channel_id -> distribution_transmission_channel * send updated ConsumerAdditionProposal * validate consumer genesis param * remove StandaloneTransferChannelID from store * fix TestOnChanOpenAck * remove state breaking change * finalize merge and fix issues * chore: update docs and changelog * chore: regenerate protos * re-add integrationt tests around changeover * mv entry in changelog * test: add sovereign to consumer changeover e2e (#1025) * tests: add sovereign to consumer e2e test * rm unused bash scripts * partially address review comments * apply remaining review comments * chore: apply formatting rules --------- Co-authored-by: Marius Poke <[email protected]> Co-authored-by: MSalopek <[email protected]> * refactor: log when constructing IBC err ack (backport #1090) (#1094) refactor: log when constructing IBC err ack (#1090) * log with err ack * linter (cherry picked from commit 07302ff) Co-authored-by: Shawn <[email protected]> * fix: `AttributeDistributionTotal` in event emit (backport #1097) (#1114) * fix: `AttributeDistributionTotal` in event emit (#1097) * fix: emitted distribution events * docs: update changelog * fix: lint --------- Co-authored-by: MSalopek <[email protected]> (cherry picked from commit d16c766) # Conflicts: # CHANGELOG.md # x/ccv/consumer/keeper/distribution.go * resolve conflicts * docs: remove v3 changelog from v2 release line --------- Co-authored-by: yaruwangway <[email protected]> Co-authored-by: Yaru Wang <[email protected]> * docs: update broken md links (backport #1130) (#1142) * docs: update broken md links (#1130) (cherry picked from commit fd76f45) # Conflicts: # docs/docs/validators/joining-testnet.md * Update joining-testnet.md --------- Co-authored-by: MSalopek <[email protected]> Co-authored-by: Shawn <[email protected]> * feat!: add ICS misbehaviour handling (#826) * define msg to submit misbehaviour to provider implement msg handling logic e2e test msg handling logic * wip: get byzantine validators in misbehavioiur handling * add tx handler * format HandleConsumerMisbehaviour * add tx handler * add debugging stuff * Add misbehaviour handler * create message for consumer double voting evidence * add DRAFT double vote handler * Add cli cmd for submit consumer double voting * Add double-vote handler * add last update * fix jailing * pass first jailing integration test * format tests * doc * save * update e2e tests' * fix typo and improve docs * remove unwanted tm evidence protofile * fix typos * update submit-consumer-misbehaviour cli description * check that header1 and header2 have the same TrustedValidators * feat: add e2e tests for ICS misbehaviour (#1118) * remove unwanted changes * fix hermes config with assigned key * revert unwanted changes * revert local setup * remove log file * typo * update doc * update ICS misbehaviour test * update ICS misbehaviour test * revert mixed commits * add doc * lint * update to handle only equivocations * improve doc * update doc * update E2E tests comment * optimize signatures check * doc * update e2e tests * linter * remove todo * Feat: avoid race condition in ICS misbehaviour handling (#1148) * remove unwanted changes * fix hermes config with assigned key * revert unwanted changes * revert local setup * remove log file * typo * update doc * update ICS misbehaviour test * update ICS misbehaviour test * revert mixed commits * update ICS misbehaviour test * update ICS misbehaviour test * Add test for MsgSubmitConsumerMisbehaviour parsing * fix linter * save progress * add CheckMisbehaviourAndUpdateState * update integration tests * typo * remove e2e tests from another PRs * cleaning' * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * update integration tests * save * save * nits * remove todo * lint * Update x/ccv/provider/keeper/misbehaviour.go --------- Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Marius Poke <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: Anca Zamfir <[email protected]> * add attributes to EventTypeSubmitConsumerMisbehaviour * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * apply review suggestions * fix docstring * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * fix link * apply review suggestions * update docstring --------- Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Marius Poke <[email protected]> * deps!: support cosmos-sdk-v45-ics-lsm integration (#1120) * tests: check cosmos-sdk-v45-ics-lsm integration * bump cosmos-sdk to inqlusion latest * support new method signatuers * fix: bump v0.45.16-ics-lsm to latest [fixes difftests] * fix: update democracy tests representative registration * chore: bump iqlusion:cosmos-sdk to latest * chore: bump iqlusion:cosmos-sdk to latest * chore: bump iqlusion:cosmos-sdk to latest * fix!: avoid panicking on CancelUnbondingDelegation (#977) * handle CancelUnbondingDelegation message * tests: add cancel-unbond e2e test * fix: appease linter * chore: Hardcode golangci-lint version (#990) * Hardcode golangci-lint version * Hardcode version in CI config --------- Co-authored-by: MSalopek <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]> * tests: fix broken cancelUnbond e2e after cherry pick * chore: regenerate mocks * chore: run make proto-gen * fix: complete concel-unbond handling in hooks * chore: bump iqlusion:cosmos-sdk to latest * chore: fix brokene gov prop submit * chore: fix brokene gov prop submit * use SDK 0.45.16-ics-lsm-rc0 * add changelog entry --------- Co-authored-by: Marius Poke <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]> * docs: add v2.0.0-lsm changelog section (#1210) add changelog section * deps: bump SDK to v0.45.16-ics-lsm (#1212) bump SDK to v0.45.16-ics-lsm * feat: improve ICS misbehaviour E2E testing coverage (#1225) * update e2e tests * update the chain halt assertion * refactor: address comments of ICS Misbehaviour PRs #826 and #1148 (#1223) * remove interface * improve comment * update godoc * address last comments * feat: add handler for consumer double voting (#1232) * create new endpoint for consumer double voting * add first draft handling logic * first iteration of double voting * draft first mem test * error handling * refactor * add unit test of double voting verification * remove evidence age checks * document * doc * protogen * reformat double voting handling * logger nit * nits * check evidence age duration * move verify double voting evidence to ut * fix nit * nits * fix e2e tests * improve double vote testing coverage * remove TODO * lint * add UT for JailAndTombstoneValidator * nits * nits * remove tombstoning and evidence age check * lint * typo * improve godoc * fix: tiny bug in `NewSubmitConsumerDoubleVotingCmd` (#1247) * fix double voting cli * fix bug double signing handler * godoc * nits * revert wrong push of lasts commits * fix: make `HandleConsumerDoubleVoting` works with provider pubkeys (#1254) * fix double voting cli * fix bug double signing handler * godoc * nits * lint * nit * fix: verify equivocation using validator pubkey in `SubmitConsumerDoubleVoting` msg (#1264) * verify dv evidence using malicious validator pubkey in infraction block header * nits * nits * refactor: update the E2E tests to work with Hermes relayer v1.6.0 (#1278) * save changes * fix hermes config * fist successful run * nit * nits * nits * doc and nits * lint * test: add E2E tests for double voting evidence handling (#1256) * fix double voting cli * add double-signing e2e test * refortmat e2e double voting test * godoc, revert unwanted changes * nit * verify dv evidence using malicious validator pubkey in infraction block header * save changes * fix hermes config * fist successful run * nit * nits * nits * doc and nits * lint * refactor * typo * change hermes docker image * nits * Update tests/e2e/steps.go Co-authored-by: Philip Offtermatt <[email protected]> * address PR comments * nits --------- Co-authored-by: Philip Offtermatt <[email protected]> * feat!: provider proposal for changing reward denoms (backport #1280) (#1291) * feat!: provider proposal for changing reward denoms (#1280) * new provider prop type * add methods and tests for new prop, update docs * remove old tx, fix tests * e2e handling * fix command type * boilerplate * fix e2e tests * Update CHANGELOG.md * lint * validate denoms * Update proposal.go * rm msg string * fix tests * rm chain in change denom action * lint * test for invalid denom * events for both add and remove * Update proposal_test.go (cherry picked from commit 48a2186) # Conflicts: # CHANGELOG.md # app/provider/app.go # proto/interchain_security/ccv/provider/v1/provider.proto # proto/interchain_security/ccv/provider/v1/tx.proto # tests/e2e/actions.go # tests/integration/distribution.go # x/ccv/provider/client/cli/tx.go # x/ccv/provider/client/proposal_handler.go # x/ccv/provider/keeper/distribution.go # x/ccv/provider/keeper/distribution_test.go # x/ccv/provider/proposal_handler_test.go # x/ccv/provider/types/codec.go # x/ccv/provider/types/proposal.go # x/ccv/provider/types/provider.pb.go # x/ccv/provider/types/tx.pb.go * fix conflicts * fix rest handler * Update CHANGELOG.md * rm uneeded tx proto --------- Co-authored-by: Shawn <[email protected]> * save * fix nits * update changelog and fix nits * feat: implement slashing functionality on the provider chain (ADR-013) (#1275) Implementing the slashing functionality, as described in ADDR, on the provider chain. * fix e2e happy-path-short test * make consumer misbehaviour and double signing tests pass * currently debugging democracy-reward * fix e2e democ test * refactor: remove equivocation proposal (#1294) * remove equivocation proposal * bring back evidencekeeper * go.sum added * rebase and fix lint issues * fix mocks * clean up protos & delete unecessary file * fix E2E test * fix Dockerfile * more fixes * increase wait attempt * increase wait attempt * wait 1 block in gov proposal * fix numbers --------- Co-authored-by: Karolos Antoniadis <[email protected]> * add equivo removal failing tests * fix democ e2e tests * make mem tests pass * lint * fix Dockerfile * update changelog * fix nits * update rapid test * fix democ tests * update changelog * fix CHANGELOG.md * nits * Update docs/docs/features/slashing.md Co-authored-by: insumity <[email protected]> * Update proto/interchain_security/ccv/provider/v1/tx.proto Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/punish_validator.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/punish_validator.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/punish_validator.go Co-authored-by: insumity <[email protected]> * check verifying pubkey against validator address * add tests * update checkMisbehaviour tests * save * update all misbehaviour memory tests * fix misb verify valset sigs test * revert misb check fix for ibc 7 * nit fix * fix nit * fix: add equivocation proposal message back in protos (#1394) * add depreacted equiv prop msg def * add codec and content for equivo proposal msg * doc * proto * fix!: verify the signatures of byzantine validators in misbehaviour handling (#1422) * update byzantine validators extraction * nits * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * last changes * udpdate changelog --------- Co-authored-by: insumity <[email protected]> * feat: update misbehaviour handling using IBC-Go 7 (#1401) * nit fix * improve doc * super picky nit * fix!: drop nil votes in misbehaviour handling (#1404) * update CHANGELOG for final release * save * update test to extract byzantine validators * improve testing * nits * nits * Update tests/integration/misbehaviour.go Co-authored-by: insumity <[email protected]> * Update testutil/crypto/evidence.go Co-authored-by: insumity <[email protected]> * update util func * doc * check misb client ID * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * nits --------- Co-authored-by: insumity <[email protected]> * fix comments * update changelog * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * improve tests * lint * udpate traces * silly bug --------- Co-authored-by: insumity <[email protected]> * nit * Update x/ccv/provider/keeper/double_vote.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/double_vote.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * Update tests/integration/double_vote.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: insumity <[email protected]> * address comments * address comments * Update x/ccv/provider/types/proposal.go Co-authored-by: Philip Offtermatt <[email protected]> * Update tests/integration/double_vote.go Co-authored-by: Philip Offtermatt <[email protected]> * Port: (feat!) [#1435](#1435) Add height-base filter for consumer equivocation evidence. * fix: update consumer double vote cmd (#1439) add cmd fix * update CHANGELOG * update changelog * update changelog entries * nits --------- Co-authored-by: Shawn <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Philip Offtermatt <[email protected]> Co-authored-by: Marius Poke <[email protected]> Co-authored-by: MSalopek <[email protected]> Co-authored-by: yaruwangway <[email protected]> Co-authored-by: Yaru Wang <[email protected]> Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: insumity <[email protected]> Co-authored-by: Karolos Antoniadis <[email protected]>

@MSalopek

* docs: cleanup changelog for v2.0.0 on release/v2.0.x (#987) * Update CHANGELOG.md * Update CHANGELOG.md * comment * chore: Hardcode golangci-lint version (backport #990) (#1013) chore: Hardcode golangci-lint version (#990) * Hardcode golangci-lint version * Hardcode version in CI config (cherry picked from commit 9920121) Co-authored-by: Philip Offtermatt <[email protected]> * fix: proper consumer key prefix ordering (backport #991) (#1011) fix: proper consumer key prefix ordering (#991) * Update keys.go * tests * fix another bug * fix comments (cherry picked from commit a1e18d0) Co-authored-by: Shawn <[email protected]> * feat: Remove consumer genesis migration on provider (backport #997) (#1012) feat: Remove consumer genesis migration on provider (#997) * Update keys.go * tests * fix another bug * remove consumer genesis deletion, link to test * remove unused bond denom method * Revert "remove unused bond denom method" This reverts commit f930eca. * remove test too * update changelog (cherry picked from commit e2ac974) Co-authored-by: Shawn <[email protected]> * fix: limit vsc matured packets handled per endblocker (backport #1004) (#1015) fix: limit vsc matured packets handled per endblocker (#1004) * initial implementation, still need tests * UTs * integration test * linter * Update CHANGELOG.md * make vsc matured handled this block a var * comment (cherry picked from commit 8c2fc56) Co-authored-by: Shawn <[email protected]> * feat: integrate cometmock (backport #989) (#1030) feat: integrate cometmock (#989) * Add gorelayer and CometMock to Dockerfile * Add option to start with cometmock in start-chain script * Start adding support for rly * Adjust relayer start action * Add entrypoint for short happy path steps * Add . nosec G204 and waiting for blocks * Adjust rly config: Gas is free * Remove optout steps from short happy path * Use separate redelegate step for short happy path * Wait for blocks after unbonding * Make naming more descriptive and add comments * Add comment to chain name sorting and improve comments * Update start-chain.sh Address comments form joint review session with @MSalopek * Fix typo (cherry picked from commit 07be71a) Co-authored-by: Philip Offtermatt <[email protected]> * feat!: Add DistributionTransmissionChannel to ConsumerAdditionProposal (manual backport #965) (#1031) feat!: Add DistributionTransmissionChannel to ConsumerAdditionProposal (#965) * update proto * remove transfer_channel_id from consumer genesis * ConsumerAdditionProposal: transfer_channel_id -> distribution_transmission_channel * send updated ConsumerAdditionProposal * validate consumer genesis param * remove StandaloneTransferChannelID from store * fix TestOnChanOpenAck * remove state breaking change * finalize merge and fix issues * chore: update docs and changelog * chore: regenerate protos * re-add integrationt tests around changeover * mv entry in changelog * test: add sovereign to consumer changeover e2e (#1025) * tests: add sovereign to consumer e2e test * rm unused bash scripts * partially address review comments * apply remaining review comments * chore: apply formatting rules --------- Co-authored-by: Marius Poke <[email protected]> Co-authored-by: MSalopek <[email protected]> * refactor: log when constructing IBC err ack (backport #1090) (#1094) refactor: log when constructing IBC err ack (#1090) * log with err ack * linter (cherry picked from commit 07302ff) Co-authored-by: Shawn <[email protected]> * fix: `AttributeDistributionTotal` in event emit (backport #1097) (#1114) * fix: `AttributeDistributionTotal` in event emit (#1097) * fix: emitted distribution events * docs: update changelog * fix: lint --------- Co-authored-by: MSalopek <[email protected]> (cherry picked from commit d16c766) * resolve conflicts * docs: remove v3 changelog from v2 release line --------- Co-authored-by: yaruwangway <[email protected]> Co-authored-by: Yaru Wang <[email protected]> * docs: update broken md links (backport #1130) (#1142) * docs: update broken md links (#1130) (cherry picked from commit fd76f45) * Update joining-testnet.md --------- Co-authored-by: MSalopek <[email protected]> Co-authored-by: Shawn <[email protected]> * feat!: add ICS misbehaviour handling (#826) * define msg to submit misbehaviour to provider implement msg handling logic e2e test msg handling logic * wip: get byzantine validators in misbehavioiur handling * add tx handler * format HandleConsumerMisbehaviour * add tx handler * add debugging stuff * Add misbehaviour handler * create message for consumer double voting evidence * add DRAFT double vote handler * Add cli cmd for submit consumer double voting * Add double-vote handler * add last update * fix jailing * pass first jailing integration test * format tests * doc * save * update e2e tests' * fix typo and improve docs * remove unwanted tm evidence protofile * fix typos * update submit-consumer-misbehaviour cli description * check that header1 and header2 have the same TrustedValidators * feat: add e2e tests for ICS misbehaviour (#1118) * remove unwanted changes * fix hermes config with assigned key * revert unwanted changes * revert local setup * remove log file * typo * update doc * update ICS misbehaviour test * update ICS misbehaviour test * revert mixed commits * add doc * lint * update to handle only equivocations * improve doc * update doc * update E2E tests comment * optimize signatures check * doc * update e2e tests * linter * remove todo * Feat: avoid race condition in ICS misbehaviour handling (#1148) * remove unwanted changes * fix hermes config with assigned key * revert unwanted changes * revert local setup * remove log file * typo * update doc * update ICS misbehaviour test * update ICS misbehaviour test * revert mixed commits * update ICS misbehaviour test * update ICS misbehaviour test * Add test for MsgSubmitConsumerMisbehaviour parsing * fix linter * save progress * add CheckMisbehaviourAndUpdateState * update integration tests * typo * remove e2e tests from another PRs * cleaning' * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * update integration tests * save * save * nits * remove todo * lint * Update x/ccv/provider/keeper/misbehaviour.go --------- Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Marius Poke <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: Anca Zamfir <[email protected]> * add attributes to EventTypeSubmitConsumerMisbehaviour * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * apply review suggestions * fix docstring * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: Anca Zamfir <[email protected]> * fix link * apply review suggestions * update docstring --------- Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Marius Poke <[email protected]> * deps!: support cosmos-sdk-v45-ics-lsm integration (#1120) * tests: check cosmos-sdk-v45-ics-lsm integration * bump cosmos-sdk to inqlusion latest * support new method signatuers * fix: bump v0.45.16-ics-lsm to latest [fixes difftests] * fix: update democracy tests representative registration * chore: bump iqlusion:cosmos-sdk to latest * chore: bump iqlusion:cosmos-sdk to latest * chore: bump iqlusion:cosmos-sdk to latest * fix!: avoid panicking on CancelUnbondingDelegation (#977) * handle CancelUnbondingDelegation message * tests: add cancel-unbond e2e test * fix: appease linter * chore: Hardcode golangci-lint version (#990) * Hardcode golangci-lint version * Hardcode version in CI config --------- Co-authored-by: MSalopek <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]> * tests: fix broken cancelUnbond e2e after cherry pick * chore: regenerate mocks * chore: run make proto-gen * fix: complete concel-unbond handling in hooks * chore: bump iqlusion:cosmos-sdk to latest * chore: fix brokene gov prop submit * chore: fix brokene gov prop submit * use SDK 0.45.16-ics-lsm-rc0 * add changelog entry --------- Co-authored-by: Marius Poke <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]> * docs: add v2.0.0-lsm changelog section (#1210) add changelog section * deps: bump SDK to v0.45.16-ics-lsm (#1212) bump SDK to v0.45.16-ics-lsm * feat: improve ICS misbehaviour E2E testing coverage (#1225) * update e2e tests * update the chain halt assertion * refactor: address comments of ICS Misbehaviour PRs #826 and #1148 (#1223) * remove interface * improve comment * update godoc * address last comments * feat: add handler for consumer double voting (#1232) * create new endpoint for consumer double voting * add first draft handling logic * first iteration of double voting * draft first mem test * error handling * refactor * add unit test of double voting verification * remove evidence age checks * document * doc * protogen * reformat double voting handling * logger nit * nits * check evidence age duration * move verify double voting evidence to ut * fix nit * nits * fix e2e tests * improve double vote testing coverage * remove TODO * lint * add UT for JailAndTombstoneValidator * nits * nits * remove tombstoning and evidence age check * lint * typo * improve godoc * fix: tiny bug in `NewSubmitConsumerDoubleVotingCmd` (#1247) * fix double voting cli * fix bug double signing handler * godoc * nits * revert wrong push of lasts commits * fix: make `HandleConsumerDoubleVoting` works with provider pubkeys (#1254) * fix double voting cli * fix bug double signing handler * godoc * nits * lint * nit * fix: verify equivocation using validator pubkey in `SubmitConsumerDoubleVoting` msg (#1264) * verify dv evidence using malicious validator pubkey in infraction block header * nits * nits * refactor: update the E2E tests to work with Hermes relayer v1.6.0 (#1278) * save changes * fix hermes config * fist successful run * nit * nits * nits * doc and nits * lint * test: add E2E tests for double voting evidence handling (#1256) * fix double voting cli * add double-signing e2e test * refortmat e2e double voting test * godoc, revert unwanted changes * nit * verify dv evidence using malicious validator pubkey in infraction block header * save changes * fix hermes config * fist successful run * nit * nits * nits * doc and nits * lint * refactor * typo * change hermes docker image * nits * Update tests/e2e/steps.go Co-authored-by: Philip Offtermatt <[email protected]> * address PR comments * nits --------- Co-authored-by: Philip Offtermatt <[email protected]> * feat!: provider proposal for changing reward denoms (backport #1280) (#1291) * feat!: provider proposal for changing reward denoms (#1280) * new provider prop type * add methods and tests for new prop, update docs * remove old tx, fix tests * e2e handling * fix command type * boilerplate * fix e2e tests * Update CHANGELOG.md * lint * validate denoms * Update proposal.go * rm msg string * fix tests * rm chain in change denom action * lint * test for invalid denom * events for both add and remove * Update proposal_test.go (cherry picked from commit 48a2186) * fix conflicts * fix rest handler * Update CHANGELOG.md * rm uneeded tx proto --------- Co-authored-by: Shawn <[email protected]> * save * fix nits * update changelog and fix nits * feat: implement slashing functionality on the provider chain (ADR-013) (#1275) Implementing the slashing functionality, as described in ADDR, on the provider chain. * fix e2e happy-path-short test * make consumer misbehaviour and double signing tests pass * currently debugging democracy-reward * fix e2e democ test * refactor: remove equivocation proposal (#1294) * remove equivocation proposal * bring back evidencekeeper * go.sum added * rebase and fix lint issues * fix mocks * clean up protos & delete unecessary file * fix E2E test * fix Dockerfile * more fixes * increase wait attempt * increase wait attempt * wait 1 block in gov proposal * fix numbers --------- Co-authored-by: Karolos Antoniadis <[email protected]> * add equivo removal failing tests * fix democ e2e tests * make mem tests pass * lint * fix Dockerfile * update changelog * fix nits * update rapid test * fix democ tests * update changelog * fix CHANGELOG.md * nits * Update docs/docs/features/slashing.md Co-authored-by: insumity <[email protected]> * Update proto/interchain_security/ccv/provider/v1/tx.proto Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/punish_validator.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/punish_validator.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/punish_validator.go Co-authored-by: insumity <[email protected]> * check verifying pubkey against validator address * add tests * update checkMisbehaviour tests * save * update all misbehaviour memory tests * fix misb verify valset sigs test * revert misb check fix for ibc 7 * nit fix * fix nit * fix: add equivocation proposal message back in protos (#1394) * add depreacted equiv prop msg def * add codec and content for equivo proposal msg * doc * proto * fix!: verify the signatures of byzantine validators in misbehaviour handling (#1422) * update byzantine validators extraction * nits * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * last changes * udpdate changelog --------- Co-authored-by: insumity <[email protected]> * feat: update misbehaviour handling using IBC-Go 7 (#1401) * nit fix * improve doc * super picky nit * fix!: drop nil votes in misbehaviour handling (#1404) * update CHANGELOG for final release * save * update test to extract byzantine validators * improve testing * nits * nits * Update tests/integration/misbehaviour.go Co-authored-by: insumity <[email protected]> * Update testutil/crypto/evidence.go Co-authored-by: insumity <[email protected]> * update util func * doc * check misb client ID * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * nits --------- Co-authored-by: insumity <[email protected]> * fix comments * update changelog * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * improve tests * lint * udpate traces * silly bug --------- Co-authored-by: insumity <[email protected]> * nit * Update x/ccv/provider/keeper/double_vote.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/double_vote.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/keeper/misbehaviour.go Co-authored-by: insumity <[email protected]> * Update tests/integration/double_vote.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: insumity <[email protected]> * Update x/ccv/provider/client/cli/tx.go Co-authored-by: insumity <[email protected]> * address comments * address comments * Update x/ccv/provider/types/proposal.go Co-authored-by: Philip Offtermatt <[email protected]> * Update tests/integration/double_vote.go Co-authored-by: Philip Offtermatt <[email protected]> * Port: (feat!) [#1435](#1435) Add height-base filter for consumer equivocation evidence. * fix: update consumer double vote cmd (#1439) add cmd fix * update CHANGELOG * update changelog * update changelog entries * nits --------- Co-authored-by: Shawn <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Philip Offtermatt <[email protected]> Co-authored-by: Marius Poke <[email protected]> Co-authored-by: MSalopek <[email protected]> Co-authored-by: yaruwangway <[email protected]> Co-authored-by: Yaru Wang <[email protected]> Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: insumity <[email protected]> Co-authored-by: Karolos Antoniadis <[email protected]>

insumity added 7 commits September 11, 2023 21:57

first version

93a0db5

fix mocks

ea87bdc

move slashing to other file and check tombstoning

177e1db

add tests that checks that Slash is called

e1bdfff

add FIXME msg

bbff2ee

small changes

dfef410

add fixme

8b49af1

insumity force-pushed the insumity/adr-013-impl-on-feat branch from 463bfd6 to 8b49af1 Compare September 11, 2023 20:20

insumity commented Sep 11, 2023

View reviewed changes

x/ccv/provider/keeper/double_vote.go Outdated Show resolved Hide resolved

insumity commented Sep 11, 2023

View reviewed changes

x/ccv/provider/keeper/punish_validator.go Outdated Show resolved Hide resolved

insumity changed the title ~~first version~~ feat: implement slashing functionality on the provider chain (ADR-013) Sep 11, 2023

fix test

bf89509

mpoke reviewed Sep 12, 2023

View reviewed changes

modified E2E tests and general cleaning up

868e0d2

insumity commented Sep 12, 2023

View reviewed changes

clean up

9ba3a3d

insumity marked this pull request as ready for review September 12, 2023 14:48

insumity requested a review from a team as a code owner September 12, 2023 14:48

mpoke and others added 2 commits September 14, 2023 15:37

undelegations are getting slashed integraiton test

d92a4c8

insumity changed the base branch from feat/ics-misbehaviour-handling to release/v2.1.x-lsm September 14, 2023 14:26

insumity and others added 4 commits September 14, 2023 16:53

Merge branch 'release/v2.1.x-lsm' into insumity/adr-013-impl-on-feat

72abcf4

fix merge issues

b46ace4

fix mocks

59d8192

fix lint issue

31c090d

sainoe reviewed Sep 21, 2023

View reviewed changes

x/ccv/provider/keeper/misbehaviour.go Outdated Show resolved Hide resolved

sainoe reviewed Sep 21, 2023

View reviewed changes

x/ccv/provider/keeper/punish_validator.go Show resolved Hide resolved

insumity changed the base branch from release/v2.1.x-lsm to feat/ics-misbehaviour-handling September 22, 2023 07:50

insumity and others added 2 commits September 22, 2023 09:52

Merge branch 'feat/ics-misbehaviour-handling' into insumity/adr-013-i…

79f8f18

…mpl-on-feat

took into account Simon's comments

ed35638

insumity commented Sep 22, 2023

View reviewed changes

lint

93c2cdb

sainoe requested review from mpoke and sainoe September 22, 2023 12:44

insumity linked an issue Sep 22, 2023 that may be closed by this pull request

Implement slashing functionality on the provider (ADR-013) #1274

Closed

sainoe approved these changes Sep 22, 2023

View reviewed changes

Use cached context to get tokens in undelegations and redelegations.

1d3ee78

mpoke reviewed Sep 25, 2023

View reviewed changes

mpoke approved these changes Sep 26, 2023

View reviewed changes

p-offtermatt reviewed Sep 26, 2023

View reviewed changes

insumity added 4 commits September 26, 2023 10:15

return the error

5c053bb

lint issue

f8633b5

take into account Philip's comments

f96f1bc

clean up

d3dc0bc

p-offtermatt approved these changes Sep 27, 2023

View reviewed changes

insumity added 3 commits September 27, 2023 10:21

fix flakey test

39bbcf5

lint issue

694dce7

fix error returns and fix flaky test in a better way

366e3b1

insumity mentioned this pull request Sep 27, 2023

refactor: RepresentativePowers to StakedTokens #1333

Merged

insumity merged commit 022cd5d into feat/ics-misbehaviour-handling Sep 27, 2023
10 checks passed

insumity deleted the insumity/adr-013-impl-on-feat branch September 27, 2023 13:26

insumity mentioned this pull request Oct 11, 2023

feat!: add cryptographic equivocation #1340

Merged

21 tasks

insumity restored the insumity/adr-013-impl-on-feat branch October 13, 2023 15:25

insumity deleted the insumity/adr-013-impl-on-feat branch January 31, 2024 13:00

insumity restored the insumity/adr-013-impl-on-feat branch January 31, 2024 13:00

insumity deleted the insumity/adr-013-impl-on-feat branch January 31, 2024 13:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement slashing functionality on the provider chain (ADR-013) #1275

feat: implement slashing functionality on the provider chain (ADR-013) #1275

insumity commented Sep 7, 2023 •

edited

Loading

insumity Sep 12, 2023

p-offtermatt Sep 26, 2023

insumity Sep 22, 2023

sainoe commented Sep 22, 2023

mpoke left a comment

mpoke Sep 25, 2023

insumity Sep 26, 2023

mpoke Sep 25, 2023

mpoke left a comment

p-offtermatt left a comment

p-offtermatt Sep 26, 2023

p-offtermatt Sep 26, 2023

p-offtermatt left a comment

feat: implement slashing functionality on the provider chain (ADR-013) #1275

feat: implement slashing functionality on the provider chain (ADR-013) #1275

Conversation

insumity commented Sep 7, 2023 • edited Loading

Description

Author Checklist

Reviewers Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sainoe commented Sep 22, 2023

mpoke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpoke left a comment

Choose a reason for hiding this comment

p-offtermatt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

p-offtermatt left a comment

Choose a reason for hiding this comment

insumity commented Sep 7, 2023 •

edited

Loading