Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Include PRs to all branches in automated tests #1299

Closed
wants to merge 1 commit into from

Conversation

p-offtermatt
Copy link
Contributor

@p-offtermatt p-offtermatt commented Sep 14, 2023

Description

Closes: NA

Enables automated tests for all PRs to each branch.
Right now, automated tests run only on PRs targetted to feat/, release/v, and main.
I don't see a reason for this, but in more complicated scenarios (like a PR to a PR to a feature branch), the current behaviour doesn't run tests.

Please lmk if the current behaviour is a safeguard against anything specific - I think there are few PRs that don't run automated tests under the current behaviour anyways

Here is a list of past PRs of the last 6 months that were not eligible for running automated tests under the current config, but are eligible under the changed config (19 prs):
https://github.com/cosmos/interchain-security/pulls?q=is%3Apr+-base%3Amain+-base%3Arelease+-base%3Afeat+created%3A%3E2023-03-17

To compare, the full list of PRs in that period (344 prs):
https://github.com/cosmos/interchain-security/pulls?q=is%3Apr+created%3A%3E2023-03-17+


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@p-offtermatt p-offtermatt requested a review from a team as a code owner September 14, 2023 07:53
@github-actions github-actions bot added the C:CI Assigned automatically by the PR labeler label Sep 14, 2023
Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this idea! Don't have context on the bill tho :P

@p-offtermatt
Copy link
Contributor Author

Since this doesn't seem very necessary and some people might specifically use branches like this to not run unnecessary CI tests, I'll close this

@MSalopek MSalopek removed their assignment Sep 15, 2023
@MSalopek MSalopek reopened this Sep 15, 2023
@MSalopek MSalopek marked this pull request as draft September 15, 2023 09:30
@MSalopek MSalopek added the other: decayed Stale issues that need follow up from commentators. Were closed for inactivity label May 2, 2024
@MSalopek
Copy link
Contributor

MSalopek commented May 2, 2024

Closing as decayed. We can reopen at a later time.

@MSalopek MSalopek closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CI Assigned automatically by the PR labeler other: decayed Stale issues that need follow up from commentators. Were closed for inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants