test: cover consumer-gov in E2E democracy tests #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainoe
commented
Oct 4, 2023
| @@ -243,11 +243,12 @@ func DefaultTestConfig() TestConfig { | |||
|
|
|||
| func DemocracyTestConfig(allowReward bool) TestConfig { | |||
| consumerGenChanges := ".app_state.ccvconsumer.params.blocks_per_distribution_transmission = \"20\" | " + | |||
| ".app_state.gov.voting_params.voting_period = \"10s\" | " + | |||
| ".app_state.gov.params.voting_period = \"10s\" | " + | |||
There was a problem hiding this comment.
Gov props weren't executed due to this typo.
There was a problem hiding this comment.
Seems bad that small things like this break things (particularly that this seems to break them silently..), good catch!
sainoe
commented
Oct 4, 2023
| @@ -173,8 +173,12 @@ func getTestFileUsageString() string { | |||
|
|
|||
| // Test runner selection | |||
| builder.WriteString("Test runner selection:\nSelection of test runners to be executed:\n") | |||
| testConfigSet := map[string]struct{}{} | |||
There was a problem hiding this comment.
Small change to remove duplicates in the test runner selection.
p-offtermatt
approved these changes
Oct 4, 2023
sainoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The consumer gov proposals in the E2E democracy tests are currently performing a no-op as they attempt to enable a param, i.e.
transfer.params.send_enabled, which is already enabled per default.This PR fixes these tests by disabling the
send_enabledparam in the democracy tests config and asserting that the consumer gov proposal process enables it as expected.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)CHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change