docs: Add more details to the test framework README #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainoe
reviewed
Oct 6, 2023
shaspitz
approved these changes
Oct 6, 2023
tests/e2e/regenerate_traces.sh
Outdated
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
|
|
|||
| go test -timeout 30s -run ^TestWriteExamples$ github.com/cosmos/interchain-security/v3/tests/e2e | |||
There was a problem hiding this comment.
Seems like this'd be more appropriate as a make target
There was a problem hiding this comment.
True, good call
MSalopek
pushed a commit
that referenced
this pull request
Dec 1, 2023
* Add more details to the test framework README * Add regnerate_traces file * Add make target for e2e traces * Remove regenerate-traces script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: N/A, minor change
Adds more information about how to run and generate traces for the e2e framework,
as suggested by @sainoe
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:prefix in the PR titlemake build-docs)