Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: cleanup integration tests #1367

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Oct 17, 2023

Related: #1349

Integration test wiring was changed and the test were updated where interface methods changed their signatures.

Notable changes:

  • evidence handling is done through sending a message instead of calling HandleEquivocationEvidence (method was made private)
  • GetTestEvidenceKeeper now returns a concrete type (evidencekeeper.Keeper)
  • GetTestMintKeeper now returns a concrete type (mintkeeper.Keeper)
  • GetTestGovKeeper now returns a concrete type because Params is now a collection and there is no getterfunc to include in the interface

Currently the setup is broken because there is no Begin/Endblock events.
This is the problem:

func (s *CCVTestSuite) registerPacketSniffer(chain *ibctesting.TestChain) {
	if s.packetSniffers == nil {
		s.packetSniffers = make(map[*ibctesting.TestChain]*packetSniffer)
	}
	p := newPacketSniffer()
	chain.App.GetBaseApp().SetStreamingManager(p)  // p does not implement the correct interface
	s.packetSniffers[chain] = p
}

Check this TODO to figure out where to pick this up.

// tests/integration/setup.go

// TODO: @MSalopek this was deprecated, figure out how to use it or ask @tbruyelle
// var _ baseapp.StreamingService = &packetSniffer{}

@MSalopek MSalopek requested a review from a team as a code owner October 17, 2023 12:50
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Oct 17, 2023
@MSalopek MSalopek merged commit c036a10 into feat/v50-upgrade Oct 17, 2023
3 of 11 checks passed
@MSalopek MSalopek deleted the masa/v50-test-cleanup branch October 17, 2023 12:52
@MSalopek MSalopek linked an issue Oct 17, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade integration testing framework for v50
1 participant