-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update rosetta import #1381
chore: update rosetta import #1381
Conversation
Thanks for the contribution! Targetting main is perfect. I added backport labels for our most recent release branches. Out of curiosity, do you have any more details about the errors you are running into that this fixes? I'm not sure we need to backport this to the 3.2.x-consumer release, too, but afaict doesn't hurt if we include it when we cut a new release and could avoid similar problems in the future. |
Thanks @p-offtermatt!
The cosmos sdk is also importing this, but a different version of this. So this PR should align the versions. And just to be clear, all I did was remove that import from the mod file, and then re-run mod tidy and it correctly updated the import. Also, now that I think about it, backporting probably won't work because of the need to run a go mod tidy. Will follow up with specific PR's. |
…1382) update ambiguous rosetta import
…umer) (#1383) update ambiguous rosetta import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the change and the comment!
Confirmed from my end that I end up with the same changes when I remove the entry from go.mod and run go mod tidy
I merged the backport PRs in the release branches already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Approve.
Updating this import resolves ambiguous import errors we were seeing while trying to add ics support to interchaintest v7
To be specific, in interchaintest I'm importing
v3.1.0
not sure of your backport policy or if I should redirect to release branch.