Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rosetta import #1381

Merged
merged 1 commit into from
Nov 6, 2023
Merged

chore: update rosetta import #1381

merged 1 commit into from
Nov 6, 2023

Conversation

boojamya
Copy link
Contributor

@boojamya boojamya commented Oct 31, 2023

Updating this import resolves ambiguous import errors we were seeing while trying to add ics support to interchaintest v7

To be specific, in interchaintest I'm importing v3.1.0 not sure of your backport policy or if I should redirect to release branch.

@boojamya boojamya marked this pull request as ready for review October 31, 2023 23:53
@boojamya boojamya requested a review from a team as a code owner October 31, 2023 23:53
@p-offtermatt
Copy link
Contributor

p-offtermatt commented Nov 1, 2023

Thanks for the contribution! Targetting main is perfect. I added backport labels for our most recent release branches.

Out of curiosity, do you have any more details about the errors you are running into that this fixes?
Would like to get the error message in here so it comes up if someone in the future searches for a similar error.

I'm not sure we need to backport this to the 3.2.x-consumer release, too, but afaict doesn't hurt if we include it when we cut a new release and could avoid similar problems in the future.

@boojamya
Copy link
Contributor Author

boojamya commented Nov 1, 2023

Thanks @p-offtermatt!
Sure, to be more specific...
I'm seeing this error:

error while importing cosmossdk.io/tools/rosetta/lib/errors: ambiguous import: found package github.com/coinbase/rosetta-sdk-go/types in multiple modules:
	github.com/coinbase/rosetta-sdk-go v0.7.9 (...go/pkg/mod/github.com/coinbase/[email protected]/types)
	github.com/coinbase/rosetta-sdk-go/types v1.0.0 (...go/pkg/mod/github.com/coinbase/rosetta-sdk-go/[email protected])

The cosmos sdk is also importing this, but a different version of this. So this PR should align the versions.

And just to be clear, all I did was remove that import from the mod file, and then re-run mod tidy and it correctly updated the import.

Also, now that I think about it, backporting probably won't work because of the need to run a go mod tidy. Will follow up with specific PR's.

Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change and the comment!
Confirmed from my end that I end up with the same changes when I remove the entry from go.mod and run go mod tidy

I merged the backport PRs in the release branches already

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Approve.

@p-offtermatt p-offtermatt merged commit f509a26 into cosmos:main Nov 6, 2023
11 checks passed
MSalopek pushed a commit that referenced this pull request Dec 1, 2023
fix ambiguous rosetta import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants